Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6418: Hard-coded secrets are security-sensitive #4661

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the go label Feb 13, 2025
@daniel-teuchert-sonarsource daniel-teuchert-sonarsource changed the title Create rule S6418 Create rule S6418: Hard-coded secrets are security-sensitive Feb 13, 2025
@daniel-teuchert-sonarsource daniel-teuchert-sonarsource marked this pull request as ready for review February 13, 2025 12:40
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a single note about the defaultsensibility's value, but otherwise this looks good to me so feel to merge as you wish!

@@ -0,0 +1,51 @@
:detections: variables/fields
:defaultsensibility: 3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php, javascript, and java are defining this to 5 (and none to 3). Perhaps worth keeping it consistent and/or change it across the board?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants