-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6418: Hard-coded secrets are security-sensitive #4661
base: master
Are you sure you want to change the base?
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a single note about the defaultsensibility's value, but otherwise this looks good to me so feel to merge as you wish!
@@ -0,0 +1,51 @@ | |||
:detections: variables/fields | |||
:defaultsensibility: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
php, javascript, and java are defining this to 5
(and none to 3
). Perhaps worth keeping it consistent and/or change it across the board?
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: