Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: S2925 Do not use Thread.Sleep() in a test #6185

Merged
merged 19 commits into from
Jun 6, 2023
Merged

New Rule: S2925 Do not use Thread.Sleep() in a test #6185

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e80fdec
Implemented S2925 for both C# and VB.NET
Oct 9, 2022
622ced9
Update analyzers/tests/SonarAnalyzer.UnitTest/TestCases/TestsShouldNo…
Corniel Apr 19, 2023
26f7db9
Fix and clean-up.
Apr 19, 2023
d93a578
Share most of IsInTestMethod logic in base class.
Apr 19, 2023
ff5895d
Invocation based.
Apr 19, 2023
eaca1f3
Extend test cases.
Apr 19, 2023
f622722
Extend Node.ToStringContains().
May 2, 2023
9b381c3
Extend tests with coverage on using Thread.Sleep via static import.
May 2, 2023
9b9bf11
Extend test to cover Thread.Sleep() within lambda's.
May 2, 2023
b5e13fd
Format cleanup of old code
pavel-mikula-sonarsource Jun 1, 2023
2b6052c
Update analyzers/src/SonarAnalyzer.Common/Rules/TestsShouldNotUseThre…
Corniel Jun 1, 2023
85a0e6a
Rename method.
Jun 2, 2023
6317716
Scaffold RSPEC
pavel-mikula-sonarsource Jun 5, 2023
2e1a0a8
Fix license headers
pavel-mikula-sonarsource Jun 5, 2023
cc26042
Bump coverage
pavel-mikula-sonarsource Jun 5, 2023
6e7e96f
Update ITs
pavel-mikula-sonarsource Jun 5, 2023
b389921
Bump coverage
pavel-mikula-sonarsource Jun 5, 2023
721e504
Fix ITs message
pavel-mikula-sonarsource Jun 5, 2023
f233d6f
RSPEC update
pavel-mikula-sonarsource Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 147 additions & 0 deletions analyzers/its/expected/akka.net/Akka.Cluster.Tests--net471-S2925.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
{
"issues": [
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1890,
"startColumn": 13,
"endLine": 1890,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1897,
"startColumn": 13,
"endLine": 1897,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1904,
"startColumn": 13,
"endLine": 1904,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1926,
"startColumn": 13,
"endLine": 1926,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1935,
"startColumn": 13,
"endLine": 1935,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1943,
"startColumn": 13,
"endLine": 1943,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1953,
"startColumn": 13,
"endLine": 1953,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1975,
"startColumn": 13,
"endLine": 1975,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1983,
"startColumn": 13,
"endLine": 1983,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1988,
"startColumn": 13,
"endLine": 1988,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1992,
"startColumn": 13,
"endLine": 1992,
"endColumn": 31
}
}
}
]
}
147 changes: 147 additions & 0 deletions analyzers/its/expected/akka.net/Akka.Cluster.Tests--net5.0-S2925.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
{
"issues": [
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1890,
"startColumn": 13,
"endLine": 1890,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1897,
"startColumn": 13,
"endLine": 1897,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1904,
"startColumn": 13,
"endLine": 1904,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1926,
"startColumn": 13,
"endLine": 1926,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1935,
"startColumn": 13,
"endLine": 1935,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1943,
"startColumn": 13,
"endLine": 1943,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1953,
"startColumn": 13,
"endLine": 1953,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1975,
"startColumn": 13,
"endLine": 1975,
"endColumn": 31
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1983,
"startColumn": 13,
"endLine": 1983,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1988,
"startColumn": 13,
"endLine": 1988,
"endColumn": 30
}
}
},
{
"id": "S2925",
"message": "Do not use 'Thread.Sleep()' in a test.",
"location": {
"uri": "sources\akka.net\src\core\Akka.Cluster.Tests\SBR\SplitBrainResolverSpec.cs",
"region": {
"startLine": 1992,
"startColumn": 13,
"endLine": 1992,
"endColumn": 31
}
}
}
]
}
Loading