SONARJAVA-5296 Report Java version via addTelemetryProperty(). #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
tomasz-tylenda-sonarsource
force-pushed
the
tt/telemetry
branch
from
d02f7d1 to
5108e80
Compare
|
tomasz-tylenda-sonarsource
requested a review
from dorian-burihabwa-sonarsource
|
As for the telemetry in tests, I think that short term we should disable it just like the Python squad did (SonarSource/sonar-python#2234, in a separate PR). Long term, I think the test should not be able to connect to servers on the Internet. |
dorian-burihabwa-sonarsource
approved these changes
Jan 29, 2025
|
PR approved, feel free to merge whenever suited |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5296