SONARJAVA-5328 S7190 Before and After transaction methods should respect the contract #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-pilastri-sonarsource
force-pushed
the
lp/S7190
branch
from
fd23577 to
e7b3935
Compare
leonardo-pilastri-sonarsource
force-pushed
the
lp/S7190
branch
from
e7b3935 to
e717bb2
Compare
| @org.springframework.beans.factory.annotation.Autowired | ||
| Object o; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
Suggested change
| @Autowired | |
| @Annotation |
Let's be a bit clearer on the intention
| } | ||
|
|
||
| @Test | ||
| void testNoSemantics() { |
There was a problem hiding this comment.
Suggested change
| void testNoSemantics() { | |
| void test_no_semantics() { |
Let's stay consistent (I think it is the preferred way).
|
|
||
| private void checkReturnType(MethodTreeImpl methodTree, String annotationName) { | ||
| if (!methodTree.returnType().symbolType().isVoid()) { | ||
| reportReturnType(methodTree, String.format(RETURN_VOID_MESSAGE, annotationName)); |
There was a problem hiding this comment.
let's inline reportReturnType, it used only here better to give more context when reading the code
| private void checkParameters(MethodTreeImpl methodTree, String annotationName) { | ||
| List<VariableTree> parameters = methodTree.parameters(); | ||
| if (!parameters.isEmpty() && parameters.stream().anyMatch(parameter -> !isParameterAllowed(parameter))) { | ||
| reportParameters(methodTree, String.format(NO_PARAMETERS_MESSAGE, annotationName)); |
There was a problem hiding this comment.
let's inline reportParameters, it used only here better to give more context when reading the code
|
erwan-serandour
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5328