Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for scope_for_authentication method #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ current_user # Available in views
redirect_back_or_to # Use when a user tries to access a page while logged out, is asked to login, and we want to return him back to the page he originally wanted
@user.external? # Users who signed up using Facebook, Twitter, etc.
@user.active_for_authentication? # Add this method to define behaviour that will prevent selected users from signing in
User.scope_for_authentication # Define this class method to add additional conditions to search for a user. Helpful for Soft Delete.
@user.valid_password?('secret') # Compares 'secret' with the actual user's password, returns true if they match
User.authenticates_with_sorcery!
```
Expand Down
16 changes: 8 additions & 8 deletions lib/sorcery/adapters/active_record_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ def find_by_oauth_credentials(provider, uid)
@user_config.provider_attribute_name => provider
}

@klass.where(conditions).first
collection.where(conditions).first
end

def find_by_remember_me_token(token)
@klass.where(@klass.sorcery_config.remember_me_token_attribute_name => token).first
collection.where(@klass.sorcery_config.remember_me_token_attribute_name => token).first
end

def find_by_credentials(credentials)
Expand All @@ -69,21 +69,21 @@ def find_by_credentials(credentials)
end
end

@klass.where(relation).first
collection.where(relation).first
end

def find_by_token(token_attr_name, token)
condition = @klass.arel_table[token_attr_name].eq(token)

@klass.where(condition).first
collection.where(condition).first
end

def find_by_activation_token(token)
@klass.where(@klass.sorcery_config.activation_token_attribute_name => token).first
collection.where(@klass.sorcery_config.activation_token_attribute_name => token).first
end

def find_by_id(id)
@klass.find_by_id(id)
collection.find_by_id(id)
end

def find_by_username(username)
Expand All @@ -92,13 +92,13 @@ def find_by_username(username)
username = username.downcase
end

result = @klass.where(attribute => username).first
result = collection.where(attribute => username).first
return result if result
end
end

def find_by_email(email)
@klass.where(@klass.sorcery_config.email_attribute_name => email).first
collection.where(@klass.sorcery_config.email_attribute_name => email).first
end

def transaction(&blk)
Expand Down
4 changes: 4 additions & 0 deletions lib/sorcery/adapters/base_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ def self.find(id)
find_by_id(id)
end

def self.collection
@klass.respond_to?(:scope_for_authentication) ? @klass.send(:scope_for_authentication) : @klass
end

def increment(field)
@model.increment(field)
end
Expand Down
18 changes: 9 additions & 9 deletions lib/sorcery/adapters/mongoid_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,51 +51,51 @@ def credential_regex(credential)

def find_by_credentials(credentials)
@klass.sorcery_config.username_attribute_names.each do |attribute|
@user = @klass.where(attribute => credential_regex(credentials[0])).first
@user = collection.where(attribute => credential_regex(credentials[0])).first
break if @user
end
@user
end

def find_by_oauth_credentials(provider, uid)
@user_config ||= ::Sorcery::Controller::Config.user_class.to_s.constantize.sorcery_config
@klass.where(@user_config.provider_attribute_name => provider, @user_config.provider_uid_attribute_name => uid).first
collection.where(@user_config.provider_attribute_name => provider, @user_config.provider_uid_attribute_name => uid).first
end

def find_by_activation_token(token)
@klass.where(@klass.sorcery_config.activation_token_attribute_name => token).first
collection.where(@klass.sorcery_config.activation_token_attribute_name => token).first
end

def find_by_remember_me_token(token)
@klass.where(@klass.sorcery_config.remember_me_token_attribute_name => token).first
collection.where(@klass.sorcery_config.remember_me_token_attribute_name => token).first
end

def transaction(&blk)
tap(&blk)
end

def find_by_id(id)
@klass.find(id)
collection.find(id)
rescue ::Mongoid::Errors::DocumentNotFound
nil
end

def find_by_username(username)
query = @klass.sorcery_config.username_attribute_names.map { |name| { name => username } }
@klass.any_of(*query).first
collection.any_of(*query).first
end

def find_by_token(token_attr_name, token)
@klass.where(token_attr_name => token).first
collection.where(token_attr_name => token).first
end

def find_by_email(email)
@klass.where(@klass.sorcery_config.email_attribute_name => email).first
collection.where(@klass.sorcery_config.email_attribute_name => email).first
end

def get_current_users
config = @klass.sorcery_config
@klass.where(
collection.where(
config.last_activity_at_attribute_name.ne => nil
).where(
"this.#{config.last_logout_at_attribute_name} == null || this.#{config.last_activity_at_attribute_name} > this.#{config.last_logout_at_attribute_name}"
Expand Down
14 changes: 14 additions & 0 deletions spec/shared_examples/user_shared_examples.rb
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,20 @@
end
end

context 'and class implements scope_for_authentication' do
it 'finds user with additional conditions' do
allow(User).to receive(:scope_for_authentication) { User.where('1 = 1') }

expect(User.authenticate(user.email, 'secret')).to eq user
end

it 'does not find user with impossible conditions' do
allow(User).to receive(:scope_for_authentication) { User.where('1 <> 1') }

expect(User.authenticate(user.email, 'secret')).to be_nil
end
end

context 'in block mode' do
it 'yields the user if credentials are good' do
User.authenticate(user.email, 'secret') do |user2, failure|
Expand Down