Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 'include_email' parameter #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding 'include_email' parameter #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d232774
adding include_email parameter
EvanBrightside Sep 11, 2017
7b8e6d3
add specs
EvanBrightside Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sorcery/providers/twitter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def initialize
super

@site = 'https://api.twitter.com'
@user_info_path = '/1.1/account/verify_credentials.json'
@user_info_path = '/1.1/account/verify_credentials.json?include_email=true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the email is good, but iirc it requires additional permissions on the app config side. I'm worried that this could potentially break existing applications, and this should probably be a optional config in-of-itself. Unfortunately though, I don't have the time currently to investigate myself.

@ebihara99999 or @EvanBrightside, can you look into how this interacts with existing apps that don't have the email permission checked? If we can confirm that it doesn't break existing apps, and/or update this to be configurable from initializer.rb, then I'd feel more comfortable merging. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. As I said I think the parameter should be optional too because it returns nil, email is nil, if the app doesn’t have granted by Twitter. It breaks not-null constraint, which is imposed almost all cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvanBrightside

Would you change codes into configurable in initializer?

See this PR
https://github.com/Sorcery/sorcery/pull/109/files

And the initializer is lib/generators/sorcery/templates/initializer.rb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it’s somehow difficult or you don’t understand very well, mention to me. Just typing with a mobile, the explanation may be too short.

end

# Override included get_consumer method to provide authorize_path
Expand Down
25 changes: 19 additions & 6 deletions spec/shared_examples/user_shared_examples.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,14 +550,27 @@ def self.matches?(crypted, *tokens)
end
end

it 'supports nested attributes' do
sorcery_model_property_set(:authentications_class, Authentication)
context 'nested attributes' do
before(:each) do
sorcery_model_property_set(:authentications_class, Authentication)
end

expect do
User.create_from_provider('facebook', '123', username: 'Noam Ben Ari')
end.to change { User.count }.by(1)
it 'supports for facebook' do
expect do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

User.create_from_provider('facebook', '123', username: 'Noam Ben Ari')
end.to change { User.count }.by(1)

expect(User.first.username).to eq 'Noam Ben Ari'
end

expect(User.first.username).to eq 'Noam Ben Ari'
it 'supports for twitter' do
expect do
User.create_from_provider('twitter', '456', username: 'Evan B', email: '[email protected]')
end.to change { User.count }.by(1)

expect(User.first.username).to eq 'Evan B'
expect(User.first.email).to eq '[email protected]'
end
end

context 'with block' do
Expand Down