-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KaaS robustness feature tests #714
base: main
Are you sure you want to change the base?
Conversation
4e8fc4d
to
6d98860
Compare
5c2f787
to
d0c4d95
Compare
There is a positive and a negative test case.
…axMutatingRequestInflight" and "minRequestTimeout".
d0c4d95
to
cbcca65
Compare
For reference, here the successful test logs of sonobuoy: cat results/plugins/scs-kaas-conformance/sonobuoy_results.yaml | yq
[Displaying results...] |
In order to make the tests pass on your K8s cluster, you would need to apply the following configurations:
Location: Apply via kubectl |
For reference, I used a self configured KubeAdm cluster to develop those tests. |
Impressive! I'm not sure I am competent to review it, but I will give it a shot. About these preconditions, wouldn't it be good to put them into a 'Testing and implementation notes' supplement? This can happen within this same PR. |
Impressive again! Just for increased safety, could you please also test on moin once we have the necessary permissions? |
I talked about including the configurations with @tonifinger. We came to the same conclusion. Also, my guess is that there will be more configuration snippets from the other tested features in other PRs. |
Sure, I can do that. |
This PR will add tests for the K8s cluster robustness features defined in the scs standard: scs-0215-v1-robustness-features
Here is a detailed listing of what is tested:
SCS-0215-v1 Robustness Features Test Coverage
1. API Server Rate Limiting
Test_scs_0215_requestLimits
Verifies basic request limit configurations
Checks API server configuration for required settings
Test_scs_0215_minRequestTimeout
Validates min-request-timeout setting
Checks configuration in API server args
Test_scs_0215_eventRateLimit
Confirms EventRateLimit admission controller configuration
Verifies plugin is enabled in API server
Test_scs_0215_apiPriorityAndFairness
Checks APF feature gate enablement
Validates API server configuration for priority and fairness
Test_scs_0215_rateLimitValues
Verifies specific rate limit values
Checks recommended settings:
QPS: 5000
Burst: 20000
2. etcd Management
Test_scs_0215_etcdCompaction
Validates compaction configuration:
Mode: periodic
Retention: 8h
Test_scs_0215_etcdBackup
Verifies backup CronJobs setup
Checks backup configuration:
Hourly backups
Daily backups
Proper paths and schedules
3. Certificate Management
Test_scs_0215_certificateRotation
Check_Certificate_Rotation_Configuration:
Verifies kubelet certificate rotation settings
Validates serverTLSBootstrap and rotateCertificates
Check_Certificate_Controller:
Confirms cert-manager deployment
Validates certificate controller functionality