Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pawprint Prototyping #250

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Conversation

rechner
Copy link
Contributor

@rechner rechner commented Jan 31, 2024

Adds pawprintprototyping.org - we are a small space in Santa Clara, California.

Furnished via the current version of the MemberMatters SpaceDirectory integration.

I've tried using the schema validator but see a 500 response from the validation backend when I try to submit, so not sure what's going on with that. The output looks correct by my eye.

@dbrgn
Copy link
Contributor

dbrgn commented Feb 1, 2024

@gidsi seems like the validator has troubles processing this URL... Maybe the Accept: application/json header is not being sent?

@dbrgn
Copy link
Contributor

dbrgn commented Feb 1, 2024

Ahh, no, it's not about the content type!

@rechner you're including the API compatibility "0.14" in your response, but it should be "14"! (After 0.13 we switched to integer based versioning.) It seems that that trips up our validator.

Could you fix that in your endpoint?

@rechner
Copy link
Contributor Author

rechner commented Feb 1, 2024

Aaah ok. I've opened a PR with the upstream maintainers, there's a couple of MemberMatters instances in the directory this would also effect.

@jabelone
Copy link
Contributor

jabelone commented Feb 2, 2024

Hey @rechner thanks for the fix. I've merged it and created a release with this fix included (v3.6.2).

However, I've looked into it further and it looks like when the PR to add support for dynamic space api sensors was merged in I didn't check that it had been implemented as per the schema (I took the contributors word that it was compatible). This means the MemberMatters space api endpoint is currently returning objects instead of an array of objects in the total_member_count and people_now_present sensors. I'll fix that up later tonight and do another release - once that is fixed our space api implementation should correctly meet the space api schema.

Additionally, I've opened an issue in the validator repo as it's very confusing when trying to test an endpoint and that endpoint provides data that can't be parsed as the validator shows no feedback in the UI.

@dbrgn
Copy link
Contributor

dbrgn commented Feb 3, 2024

@jabelone thanks for opening the validator issue! I agree that an error should be shown. (The root issue is probably that the validator doesn't know which schema to load becaues it doesn't know "0.14", and doesn't show a clean error message.)

Regarding MemberMatters, if it supports SpaceAPI, it would be nice if it could get listed at https://spaceapi.io/provide-an-endpoint/ ! You can find instructions on how to do that in the README at https://github.com/SpaceApi/website

@rnestler
Copy link
Member

rnestler commented Mar 7, 2024

@rechner The validator shows two errors: https://validator.spaceapi.io/ui/?url=https://members.pawprintprototyping.org/api/spacedirectory/

    "people_now_present": {
      "value": 0
    },

    "total_member_count": {
      "value": 25
    }

Both should be arrays of objects (see https://spaceapi.io/docs/#schema-key-sensors):

    "people_now_present": [{
      "value": 0
    }],

    "total_member_count": [{
      "value": 25
    }]

@rnestler
Copy link
Member

@rechner @jabelone any update on this?

@jabelone
Copy link
Contributor

jabelone commented Apr 8, 2024

@rechner @rnestler membermatters/membermatters:v3.6.3 is now available on docker hub. Let me know how it goes! Our instance passes the space api validator so hopefully this is resolved now. Sorry for the hassle! :)

@jabelone
Copy link
Contributor

jabelone commented Apr 8, 2024

@dbrgn I've also added a PR here to add Member Matters to the website.

@rnestler rnestler requested a review from a team April 26, 2024 09:23
@rnestler
Copy link
Member

rnestler commented Apr 26, 2024

@rechner The validator still returns an error: https://validator.spaceapi.io/ui/?url=https://members.pawprintprototyping.org/api/spacedirectory/. I guess you need to update the membermatters version?

@rechner
Copy link
Contributor Author

rechner commented Apr 26, 2024

hi @rnestler - sorry about the long TTL, I've got our version updated and the validator is passing now. I appreciate the patience!

Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@s3lph s3lph merged commit 7113bc6 into SpaceApi:master Apr 27, 2024
1 check passed
@rechner rechner deleted the rechner-patch-1 branch May 31, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants