-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pawprint Prototyping #250
Conversation
@gidsi seems like the validator has troubles processing this URL... Maybe the |
Ahh, no, it's not about the content type! @rechner you're including the API compatibility "0.14" in your response, but it should be "14"! (After 0.13 we switched to integer based versioning.) It seems that that trips up our validator. Could you fix that in your endpoint? |
Aaah ok. I've opened a PR with the upstream maintainers, there's a couple of MemberMatters instances in the directory this would also effect. |
Hey @rechner thanks for the fix. I've merged it and created a release with this fix included ( However, I've looked into it further and it looks like when the PR to add support for dynamic space api sensors was merged in I didn't check that it had been implemented as per the schema (I took the contributors word that it was compatible). This means the MemberMatters space api endpoint is currently returning objects instead of an array of objects in the Additionally, I've opened an issue in the validator repo as it's very confusing when trying to test an endpoint and that endpoint provides data that can't be parsed as the validator shows no feedback in the UI. |
@jabelone thanks for opening the validator issue! I agree that an error should be shown. (The root issue is probably that the validator doesn't know which schema to load becaues it doesn't know "0.14", and doesn't show a clean error message.) Regarding MemberMatters, if it supports SpaceAPI, it would be nice if it could get listed at https://spaceapi.io/provide-an-endpoint/ ! You can find instructions on how to do that in the README at https://github.com/SpaceApi/website |
@rechner The validator shows two errors: https://validator.spaceapi.io/ui/?url=https://members.pawprintprototyping.org/api/spacedirectory/ "people_now_present": {
"value": 0
},
"total_member_count": {
"value": 25
} Both should be arrays of objects (see https://spaceapi.io/docs/#schema-key-sensors): "people_now_present": [{
"value": 0
}],
"total_member_count": [{
"value": 25
}] |
@rechner The validator still returns an error: https://validator.spaceapi.io/ui/?url=https://members.pawprintprototyping.org/api/spacedirectory/. I guess you need to update the membermatters version? |
hi @rnestler - sorry about the long TTL, I've got our version updated and the validator is passing now. I appreciate the patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Adds pawprintprototyping.org - we are a small space in Santa Clara, California.
Furnished via the current version of the MemberMatters SpaceDirectory integration.
I've tried using the schema validator but see a 500 response from the validation backend when I try to submit, so not sure what's going on with that. The output looks correct by my eye.