feature/SPRIND-61_conformance-fixes #48
Conversation
… Veramo APIs" This reverts commit a6e506b.
| }) | ||
| ) | ||
| )).filter(signature => signature !== undefined ) as JwsJsonSignatureWithIdentifier[] |
There was a problem hiding this comment.
This cannot be correct. We now all of a sudden return less objects than we should. Why is this change needed?
There was a problem hiding this comment.
I am possibly adding undefined elements on line 432. I need to return JwsJsonSignatureWithIdentifier[] , not (JwsJsonSignatureWithIdentifier | undefined)[]
There was a problem hiding this comment.
Yes, but the whole point is that you started introducing this. If for whatever reason the signature could be empty (which according to the spec it really can't for a jws json general AFAIK), then it still should return the identifiers, not all of a sudden filter everything out.
But IMO this change reeks of something else going wrong when calling this function. So it should be solved outside of this function. If we really need this then we probably need something like an explicit param that allows the new behaviour (and only when that param is set)
feature/SPRIND-60
Feature/sprind 61 jwe
No description provided.