Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spalloc Server integration testing #76

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Spalloc Server integration testing #76

wants to merge 24 commits into from

Conversation

dkfellows
Copy link
Member

No description provided.

@dkfellows dkfellows added the jenkins trigger Only used to trigger integration testing of other repositories label Sep 23, 2021
@dkfellows dkfellows self-assigned this Sep 23, 2021
@dkfellows dkfellows changed the title jenkins trigger Spalloc Server integration testing Sep 23, 2021
Jenkinsfile Outdated
@@ -271,10 +255,28 @@ pipeline {
}
}

def makeConfig(String filename) {
//def spalloc = 'spalloc://[email protected]:22246'
def spalloc = 'spalloc://[email protected]:22246'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - the internal IP address is used as both the Jenkins server and the machine have addresses on this internal network. Using the external IP means that traffic is likely to flow out of and in to the machine room i.e. the tests become more dependent on the networking state outside of the machine room.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but tests fail catastrophically if I do that. I'm guessing there's some sort of iptables issue causing trouble. (Configuring /etc/hosts is better than using hardcoded IP addresses.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably means that the service isn't listening on all IP addresses. I believe that you can fix this by adding:
address: 0.0.0.0
to the yml file here (or whereever the actual config comes from):
https://github.com/SpiNNakerManchester/JavaSpiNNaker/blob/spalloc-server/SpiNNaker-allocserv/src/main/resources/application.yml#L57

@dkfellows
Copy link
Member Author

Note that this depends on having a server instance up already. It doesn't stand up a new instance for the tests.

@dkfellows dkfellows removed the jenkins trigger Only used to trigger integration testing of other repositories label Feb 27, 2023
@dkfellows dkfellows removed their assignment Feb 27, 2023
@dkfellows dkfellows added the enhancement New feature or request label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

2 participants