-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spalloc Server integration testing #76
base: main
Are you sure you want to change the base?
Conversation
Jenkinsfile
Outdated
@@ -271,10 +255,28 @@ pipeline { | |||
} | |||
} | |||
|
|||
def makeConfig(String filename) { | |||
//def spalloc = 'spalloc://[email protected]:22246' | |||
def spalloc = 'spalloc://[email protected]:22246' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - the internal IP address is used as both the Jenkins server and the machine have addresses on this internal network. Using the external IP means that traffic is likely to flow out of and in to the machine room i.e. the tests become more dependent on the networking state outside of the machine room.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but tests fail catastrophically if I do that. I'm guessing there's some sort of iptables issue causing trouble. (Configuring /etc/hosts
is better than using hardcoded IP addresses.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably means that the service isn't listening on all IP addresses. I believe that you can fix this by adding:
address: 0.0.0.0
to the yml file here (or whereever the actual config comes from):
https://github.com/SpiNNakerManchester/JavaSpiNNaker/blob/spalloc-server/SpiNNaker-allocserv/src/main/resources/application.yml#L57
Note that this depends on having a server instance up already. It doesn't stand up a new instance for the tests. |
https://github.com/SpiNNakerManchester/IntegrationTests into spalloc-server-jdbc
No description provided.