Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOR related models and provenance #1152

Open
wants to merge 159 commits into
base: master
Choose a base branch
from
Open

VOR related models and provenance #1152

wants to merge 159 commits into from

Conversation

andrewgait
Copy link
Contributor

@andrewgait andrewgait commented Mar 3, 2022 •
edited
Loading

This is a selection of new models and provenance from the icub_vor branches, namely:

  • STDP models relating to MF-VN (vestibular nuclei) and PF-PC (purkinjie cells), both in terms of new timing and weight rules but also new synapse dynamics implementations relating to these
  • extra provenance information to be extracted to the database (see also the SpiNNFrontEndCommon PR VOR related models and provenance SpiNNFrontEndCommon#927)
  • there is also a new build called IFCondExpCerebellum, though in this instance the only difference between it and IFCondExp is the neuron model NeuronModelLeakyIntegrateAndFireTLast, which appears at first glance just to have an additional state variable which is currently unused. I am in the process of finding out whether this is/was unfinished work...
  • there is some additional code for spike profiling which we may or may not want to keep
  • there are a few minor changes to the main C code but I don't believe any of them affect performance at all

There are also probably a few comments and print statements left in here by mistake which I will try to weed out but if you spot any during a review please flag them.

Other PRs to merge with this one:
SpiNNakerManchester/vor_cerebellum#10
SpiNNakerManchester/PyNNExamples#78
SpiNNakerManchester/SpiNNGym#37
SpiNNakerManchester/SpiNNFrontEndCommon#927

Tested by SpiNNakerManchester/IntegrationTests#102

ChiaraBartolozzi and others added 30 commits October 8, 2018 15:36
@ChiaraBartolozzi
changes to compile code on Chiara's MAC
17735ff
@oliverrhodes
Sketched out cerebellum neuron model and plasticity update
6e6d5bc
@oliverrhodes
add logging to timing initialisation
c4385e8
@oliverrhodes
Add potentiation on PF spike
e0e03c4
@ChiaraBartolozzi
added look up table for PFPC learning rule
1bc6fdc
@oliverrhodes
Configure to use exp_sin_lookup
f1b0060
@oliverrhodes
add back dt printing
67f3ecd
@oliverrhodes
add missing variable initialisation
7efaf58
@oliverrhodes
Sorry Chiara - this extra variable misaligned things!
58a3f2b
@oliverrhodes
Add logging of exp_sin table lookup
5d335c9
@oliverrhodes
Tweak logging and reading of exp_sin_lut
ea065da
@ChiaraBartolozzi
added prints
99f7d3a
@ChiaraBartolozzi
Merge branch 'icub_vor' of
21d40c8 
https://github.com/SpiNNakerManchester/sPyNNaker.git into icub_vor

Conflicts:
	spynnaker/pyNN/models/neuron/plasticity/stdp/common/plasticity_helpers.py
@oliverrhodes
Implemented depression for single spike cases
a2af197
@oliverrhodes
It works!!
fa3e30a
@oliverrhodes
add template code for vn neurons
cc5b5e9
@oliverrhodes
Merge remote-tracking branch 'origin/master' into icub_vor
a8fa4f3 
Conflicts:
	neural_modelling/src/neuron/implementations/neuron_impl_semd.h
	neural_modelling/src/neuron/implementations/neuron_impl_standard.h
@oliverrhodes
Update to separate synapse dynamics for cerebellum neurons
17881a6
@oliverrhodes
Add template code for Mossy-Fibre/Vestibular Nuclei plasticity
080f877
@oliverrhodes
Correct naming mismatch
2b88adb
@oliverrhodes
Tidy PFPC LUT generation
4ad4207
@oliverrhodes
Add MFVN LUT generation and configuration code
f31196e
@oliverrhodes
Add mossy fibre plasticity
56d0318
@oliverrhodes
Add forward processing of mfvn spikes
d02781d
@oliverrhodes
Bubble down kernel/plasticity config params
55798ba
@oliverrhodes
Simplify PFPC LUT generation
32cdb96
@oliverrhodes
Updates to logging for testing in real network
2b4ea00
@ChiaraBartolozzi
Merge remote-tracking branch 'origin/master' into icub_vor
602e726 
Conflicts:
	spynnaker/pyNN/models/neuron/neuron_models/__init__.py
	spynnaker/pyNN/models/neuron/plasticity/stdp/common/plasticity_helpers.py
@ChiaraBartolozzi
run forever working and correct addresses as output
d506885
@oliverrhodes
Merge remote-tracking branch 'origin/master' into icub_vor
04f3298 
Conflicts:
	neural_modelling/makefiles/neuron/Makefile
	neural_modelling/src/neuron/plasticity/stdp/post_events.h
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
af83ea5
@andrewgait
Provenance not under debug; make STDP naming more consistent
49aba30
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
617be97
@andrewgait
Merge branch 'master' into icub_vor_update
02c5eeb
@andrewgait
Update license on new files
741a51a
@andrewgait
Update license
f7a2d53
@andrewgait
Update license on new file
bbd42f5
@andrewgait
Update licenses
f1289b0
@andrewgait
Merge branch 'master' into icub_vor_update
f4d4175
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
50a34d9 
Conflicts:
	spynnaker/pyNN/models/neuron/abstract_pynn_neuron_model.py
	spynnaker/pyNN/models/neuron/abstract_pynn_neuron_model_standard.py
	spynnaker/pyNN/models/neuron/synapse_dynamics/abstract_synapse_dynamics.py
@andrewgait
Merge branch 'master' into icub_vor_update
13aba6e
@andrewgait
Merge branch 'master' into icub_vor_update
ccf8772
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
379331e
@andrewgait
DataType has moved
cb27cfb
@andrewgait
Update OS to use newer compiler
e9f5c85
@andrewgait
Remove unneeded print statements
35c3d27
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
4e45004
@andrewgait
Merge branch 'master' into icub_vor_update
0064270
@andrewgait
Tidy up C code
32df07a
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
f8d7701
@andrewgait
Tidy up python code
32535ef
@andrewgait
flake8
6cfe9e5
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
5101db1
@andrewgait
Merge branch 'master' into icub_vor_update
69cc5af
@coveralls
Copy link

coveralls commented Sep 18, 2023 •
edited
Loading

Coverage Status

coverage: 61.17% (-0.2%) from 61.322% when pulling 32692be on icub_vor_update into 7f5f333 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-B Christian-B Awaiting requested review from Christian-B

@pabogdan pabogdan Awaiting requested review from pabogdan

@rowleya rowleya Awaiting requested review from rowleya

Assignees
No one assigned
Labels
enhancement incomplete_left_for_further_release Postponed past a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewgait @coveralls @ChiaraBartolozzi @oliverrhodes @pabogdan