Fix possible NPE when trying to get encoder protocol

[BoomEaro]

This pull request fixes a rare race condition where the proxy can try to send a packet to a queue when the connection to the player has already been closed and netty has managed to clear all handlers, including MinecraftEncoder and MinecraftDecoder, causing a NullPointerException.

This can usually happen when a player who is already trying to connect to another server unexpectedly disconnects from the proxy, and when the server the player was connecting to kicks the player, which in rare cases causes a connection error message to be sent to the player whose connection is already closed.

The solution to the problem seems simple:
Just return null for those methods that return Protocol if there are no handlers.
Schedule eventloop to add packets to the queue when necessary.

[NEZNAMY]

I can confirm that this issue is indeed happening currently, even when using the official API. The PR looks good.

[Outfluencer]

i would just check

if ch.isClosed() { return }

in serverconnection and userconnection #sendPacketQueued

[BoomEaro]

i would just check

if ch.isClosed() { return }

in serverconnection and userconnection #sendPacketQueued

I don't think this will fix this problem.
It may happen that isClosed will return false at first, but then at the same time the channel will close and the handlers will be removed from netty and all this in the same context while the sendPacketQueued method was being executed.
It looks like this is exactly what is happening, since I looked at the source code of the Tab plugin from NEZNAMY, there is already such a check and it does not change the situation in any way.
In other words, there will be another race condition where isClosed can become outdated while this method is being executed.

[Outfluencer]

everything can be an racecondition for this specific case, as it can be invoked indirect via api (that can be executed async). I think just wrap it with an eventloop execute is the most secure way

edit: and check if the connection is already closed inside the eventloop

[jquery-package]

Any updates on this? @BoomEaro

[Outfluencer]

looks good to me, have you tested it?

[BoomEaro]

looks good to me, have you tested it?

Everything seems to work fine, but I'll try to test it some more