Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pyedflib version after breaking change in annotations #3644

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Pin pyedflib version after breaking change in annotations #3644

merged 1 commit into from
Jan 27, 2025

Conversation

alejoe91
Copy link
Member

@alejoe91 alejoe91 commented Jan 27, 2025 •
edited
Loading

Changed sample_rate to sample_frequency in annotations: https://github.com/holgern/pyedflib/releases/tag/v0.1.39

Fixed in NEO here: NeuralEnsemble/python-neo#1635

@alejoe91 alejoe91 added the extractors Related to extractors module label Jan 27, 2025
@alejoe91 alejoe91 mentioned this pull request Jan 27, 2025
Merged
@alejoe91 alejoe91 requested review from h-mayorquin and zm711 January 27, 2025 17:05
zm711
zm711 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@zm711 zm711 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I haven't looked to see who is in charge of this IO for neo, but we will find someone to assign it to :)

Did you open an issue in neo?

h-mayorquin
h-mayorquin approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation of sampling_rate I think.

@alejoe91
Copy link
Member Author

Sounds good. I haven't looked to see who is in charge of this IO for neo, but we will find someone to assign it to :)

Did you open an issue in neo?

Fixed in NEO here: NeuralEnsemble/python-neo#1635

@alejoe91 alejoe91 merged commit c5d3055 into SpikeInterface:main Jan 27, 2025
14 of 15 checks passed
@h-mayorquin h-mayorquin mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 approved these changes

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
extractors Related to extractors module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alejoe91 @h-mayorquin @zm711