World Template Fixes #4004
Closed
World Template Fixes #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you miss me? Signed-off-by: Chris Sanders <[email protected]>
Devs need to provide the WorldType key in the template always. Signed-off-by: Chris Sanders <[email protected]>
Signed-off-by: Chris Sanders <[email protected]>
Fixes client saves accidentally declaring as hardcore allowed. Signed-off-by: Chris Sanders <[email protected]>
Signed-off-by: Chris Sanders <[email protected]>
It makes far better sense to send back an exception instead of just returning a null. As the plugin is definitely in an illegal state and somehow got this data. Signed-off-by: Chris Sanders <[email protected]>
On the SpongeVanilla client, it is full intentional for client saves to be entered and exited. Upon enter, the Vanilla client bootstraps the server and we load in server-level registries and register them. On a dedicated server, this process occurs once. However, it repeats on the client. When it does, the code rightfully crashes. This commit is a very dirty temp fix for this problem by allowing certain registries to bypass the freeze and replace the instance. The Vanilla registry system handled this challenge via the RegistryLayer system. A long term fix would be to change the Sponge registry implementation to sit on top of Mojang's work. Signed-off-by: Chris Sanders <[email protected]>
Signed-off-by: Chris Sanders <[email protected]>
Signed-off-by: Chris Sanders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponge | SpongeAPI