Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom TicketTypes to be created by plugins. #2453

Merged
merged 4 commits into from
May 18, 2024

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Mar 19, 2023

SpongeAPI | Sponge

  • Remove TicketTypes from being in the registry. They are not within the
    registry whatsoever in the base game nor is a resource id required to
    create them. Thus being impossible to maintain that contract

Signed-off-by: Chris Sanders [email protected]

@ImMorpheus ImMorpheus added the api: 10 version: 1.19 label Nov 3, 2023
@aromaa aromaa force-pushed the feature/custom-ticket-types branch from 3dd0482 to 3bf10f8 Compare May 4, 2024 21:58
@aromaa aromaa changed the base branch from api-10 to api-11 May 4, 2024 21:58
@aromaa aromaa marked this pull request as ready for review May 4, 2024 22:01
@aromaa aromaa added api-11 version: 1.20 and removed api: 10 version: 1.19 labels May 4, 2024
Zidane and others added 4 commits May 17, 2024 19:14
- Remove TicketTypes from being in the registry. They are not within the
  registry whatsoever in the base game nor is a resource id required to
  create them. Thus being impossible to maintain that contract

Signed-off-by: Chris Sanders <[email protected]>
@aromaa aromaa force-pushed the feature/custom-ticket-types branch from 3bf10f8 to aa4b970 Compare May 17, 2024 16:29
@aromaa aromaa merged commit aca1dea into api-11 May 18, 2024
7 of 9 checks passed
@aromaa aromaa deleted the feature/custom-ticket-types branch May 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-11 version: 1.20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants