Frontend refactor #161
Merged
Frontend refactor #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerBloom
force-pushed
the
frontend-refactor
branch
2 times, most recently
from
814968d to
b80206d
Compare
TylerBloom
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Looks good all and all. There is a fair amount of dead code that is commented out. Please remove this (most of it I left suggestions for, so deleting it should be a single click). Also, please run cargo clippy (and, if you want some autofixes, cargo clippy --fix) followed by cargo fmt.
…dated to use session data
…ompat layer from client diectory to root
Starting work on refactoring viewer components.
- Moved "send_op_result" from viewer to the wrapper component. - Pairings, Standings, and Overview components are now wrapped in the wrapper.
Progress on refactor for the player.
Note: the places where the subcomponents update the tournament still need to be routed through the wrapper, however this doesn't seem to immediately cause any errors.
Updated the update functionality to reflect both the refactor and the changes modifying the permissions of certain types of users.
TylerBloom
force-pushed
the
account-creation
branch
from
0053c64 to
8cf0386
Compare
TylerBloom
force-pushed
the
frontend-refactor
branch
from
0a18edc to
74c5d2f
Compare
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 30.64% 29.95% -0.69%
==========================================
Files 78 79 +1
Lines 3834 3922 +88
==========================================
Hits 1175 1175
- Misses 2659 2747 +88
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fintanneff
force-pushed
the
frontend-refactor
branch
from
73554cc to
94cf6f6
Compare
Used TournQuery alias where applicable.
TylerBloom
force-pushed
the
frontend-refactor
branch
from
4b4bddf to
50405fc
Compare
TylerBloom
force-pushed
the
frontend-refactor
branch
2 times, most recently
from
deb24ca to
812e647
Compare
TylerBloom
force-pushed
the
frontend-refactor
branch
from
812e647 to
aa0e3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to pull the current progress on the fronted refactor onto the account creation branch.