This repository has been archived by the owner on Sep 26, 2022. It is now read-only.
Added AJAX support. #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SriNandan33
suggested changes
Oct 3, 2019
There was a problem hiding this comment.
@conk3r353 , I have requesed for few changes. Please take a look at them. Thanks!
| response=json.dumps({ | ||
| 'error': 'User not found' | ||
| }), | ||
| status=502, |
There was a problem hiding this comment.
should we use 400 status code here instead of 502?
|
|
||
| response = Response( |
There was a problem hiding this comment.
Please note that, follow, unfollow is broken in user popup. Please hover over some user profile links to see the user popup.
| btn.onclick = stopFollowing; | ||
| btn.id = 'unfollow'; | ||
| btn.innerText = 'Unfollow'; | ||
| console.log('gotem'); |
There was a problem hiding this comment.
please increase/decrease the follower count if the request is successful, modify the view functions accordingly.
There was a problem hiding this comment.
can you also show flash messages when user follows/unfollows the other user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I added AJAX support, as was asked in issue #5