Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busco-prok fix #855

Merged
merged 1 commit into from
Jan 26, 2024
Merged

busco-prok fix #855

merged 1 commit into from
Jan 26, 2024

Conversation

Kincekara
Copy link
Collaborator

bacteria_odb is not accessible when a volume binds to /data folder. This is a problem for cromwell and terra applications. Running "busco --download" command in root makes db path /busco_downloads/lineages/...

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know!

@erinyoung
Copy link
Contributor

What tag do you want to use? 5.6.1-prok-bacteria_odb10_2024-01-08-1 ?

@erinyoung erinyoung merged commit 88b41f1 into StaPH-B:master Jan 26, 2024
2 checks passed
@Kincekara
Copy link
Collaborator Author

Kincekara commented Jan 26, 2024

I don't think anyone except me pulled it yet. We can overwrite it to 5.6.1-prok-bacteria_odb10_2024-01-08 🙊

@kapsakcj
Copy link
Collaborator

kapsakcj commented Jan 26, 2024

just chiming in to state my 2 cents - I would overwrite the existing tag since this image and tag are so new.

This PR is a bug fix anyways so if someone was using it previously, they shouldn't be caught off guard and will likely benefit from the change

@Kincekara Kincekara deleted the busco-prok-fix branch January 31, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants