Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polypolish 0.6.0 #876

Merged
merged 4 commits into from
Feb 21, 2024
Merged

polypolish 0.6.0 #876

merged 4 commits into from
Feb 21, 2024

Conversation

erinyoung
Copy link
Contributor

Polypolish has had a recent breaking update.

Notably, the removal of polypolish_insert_filter.py, which changes how this tool is used.

I copied the prior Dockerfile, but I've made some substantial changes:

  • there is now a builder stage, which uses rust as its base
    • polypolish is now built from source and the copied to the app stage
  • the test had to change to accommodate the removal of polypolish_insert_filter.py
  • added CMD layer

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Collaborator

Just asking out of curiosity; is the prebuilt binary not working on Jammy?

@erinyoung
Copy link
Contributor Author

I initially tried the prebuilt binary and ran into issues. Unfortunately I didn't keep any notes and I don't remember what those issues were.

@Kincekara
Copy link
Collaborator

Thank you for your reply and changes. This looks great. I am merging it.

@Kincekara Kincekara merged commit 8c621ed into master Feb 21, 2024
2 checks passed
@Kincekara
Copy link
Collaborator

Thank you for putting altogether this!
You can check the image deployment from here: https://github.com/StaPH-B/docker-builds/actions/runs/7995283808.

@erinyoung erinyoung deleted the erin-polypolish branch March 6, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants