Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds gubbins #887

Merged
merged 3 commits into from
Feb 27, 2024
Merged

adds gubbins #887

merged 3 commits into from
Feb 27, 2024

Conversation

Kincekara
Copy link
Collaborator

Closes #885

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara marked this pull request as ready for review February 26, 2024 16:48
Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gubbins is a great addition to this repo!

Tests looked like they worked : https://github.com/StaPH-B/docker-builds/actions/runs/8052286962/job/21992086832?pr=887

I have no changes to recommend

I'm going to

  1. merge this PR
  2. deploy to dockhub and quay with both the 3.3.3 and latest tags

@erinyoung erinyoung merged commit 5a4a023 into StaPH-B:master Feb 27, 2024
2 checks passed
@erinyoung
Copy link
Contributor

Thank you for putting this together!

You can check the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/8068560121

@Kincekara Kincekara deleted the gubbins branch February 27, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Container Request]: Gubbins
2 participants