-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds verkko #890
adds verkko #890
Conversation
That's a lot of output for the test stage
|
verkko/2.0/Dockerfile
Outdated
RUN verkko -d asm --hifi ./hifi.fastq.gz --nano ./ont.fastq.gz &&\ | ||
head asm/assembly.hifi-coverage.csv &&\ | ||
head asm/assembly.fasta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prints a lot to the screen. I have a hunch that head asm/assembly.fasta
might the culprit. Can we try something like wc -l asm/assembly.fasta
?
#11 225.4 resources: tmpdir=/tmp
#11 225.4
#11 225.4 Reading graph from stdin
#11 225.4 [Tue Feb 27 17:49:59 2024]
#11 225.4 Finished job 0.
#11 225.4 64 of 64 steps (100%) done
#11 225.4 Complete log: .snakemake/log/2024-02-27T174614.567918.snakemake.log
#11 225.5 node coverage length
#11 225.5 utig4-0 23.78 3421198
#11 225.5 utig4-1 7.67 4526
#11 225.5 utig4-2 8.00 4518
#11 225.5 >contig-0000001
#11 225.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think contig sequences are written in one line, so head gives a lot of outbut. I limit output with 1000 bytes. That should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
It's much easier to read now.
I think the image looks good, and I'd like to approve it. The test, however, is really hard to evaluate since there's a fasta that takes up the majority of the lines available. Do you think we can adjust it in someway? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together!
I'm going to
- merge this PR
- deploy to dockehub and quay with the
2.0
andlatest
tags.
Thank you for your contribution! You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/8084711814 |
Closes #820
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)