Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds verkko #890

Merged
merged 2 commits into from
Feb 28, 2024
Merged

adds verkko #890

merged 2 commits into from
Feb 28, 2024

Conversation

Kincekara
Copy link
Collaborator

Closes #820

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara Kincekara marked this pull request as ready for review February 28, 2024 13:06
@erinyoung
Copy link
Contributor

That's a lot of output for the test stage

#11 225.5 [output clipped, log limit 2MiB reached]

Comment on lines 47 to 49
RUN verkko -d asm --hifi ./hifi.fastq.gz --nano ./ont.fastq.gz &&\
head asm/assembly.hifi-coverage.csv &&\
head asm/assembly.fasta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prints a lot to the screen. I have a hunch that head asm/assembly.fasta might the culprit. Can we try something like wc -l asm/assembly.fasta?

#11 225.4     resources: tmpdir=/tmp
#11 225.4 
#11 225.4 Reading graph from stdin
#11 225.4 [Tue Feb 27 17:49:59 2024]
#11 225.4 Finished job 0.
#11 225.4 64 of 64 steps (100%) done
#11 225.4 Complete log: .snakemake/log/2024-02-27T174614.567918.snakemake.log
#11 225.5 node	coverage	length
#11 225.5 utig4-0	23.78	3421198
#11 225.5 utig4-1	7.67	4526
#11 225.5 utig4-2	8.00	4518
#11 225.5 >contig-0000001
#11 225.5 

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think contig sequences are written in one line, so head gives a lot of outbut. I limit output with 1000 bytes. That should work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It's much easier to read now.

@erinyoung
Copy link
Contributor

I think the image looks good, and I'd like to approve it. The test, however, is really hard to evaluate since there's a fasta that takes up the majority of the lines available. Do you think we can adjust it in someway?

Copy link
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together!

I'm going to

  1. merge this PR
  2. deploy to dockehub and quay with the 2.0 and latest tags.

@erinyoung erinyoung merged commit dee8fcb into StaPH-B:master Feb 28, 2024
2 checks passed
@erinyoung
Copy link
Contributor

Thank you for your contribution!

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/8084711814

@Kincekara Kincekara deleted the verkko branch February 28, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Container Request]: Verkko
2 participants