remove traceback from errors

StackStorm · Jul 3, 2023 · e0ee182 · e0ee182
1 parent 71ced16
commit e0ee182
Showing 1 changed file with 28 additions and 0 deletions.
diff --git a/st2tests/integration/orquesta/test_wiring_error_handling.py b/st2tests/integration/orquesta/test_wiring_error_handling.py
@@ -67,6 +67,10 @@ def test_inspection_error(self):
         ex = self._execute_workflow("examples.orquesta-fail-inspection")
         ex = self._wait_for_completion(ex)
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
+        # delete the traceback key here since it provides no value to the
+        # testing
+        for i in ex.result["errors"]:
+            i.pop("traceback")
         self.assertDictEqual(ex.result, {"errors": expected_errors, "output": None})
 
     def test_input_error(self):
@@ -84,6 +88,8 @@ def test_input_error(self):
         ex = self._execute_workflow("examples.orquesta-fail-input-rendering")
         ex = self._wait_for_completion(ex)
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
         self.assertDictEqual(ex.result, {"errors": expected_errors, "output": None})
 
     def test_vars_error(self):
@@ -101,6 +107,9 @@ def test_vars_error(self):
         ex = self._execute_workflow("examples.orquesta-fail-vars-rendering")
         ex = self._wait_for_completion(ex)
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
+
         self.assertDictEqual(ex.result, {"errors": expected_errors, "output": None})
 
     def test_start_task_error(self):
@@ -128,6 +137,9 @@ def test_start_task_error(self):
 
         ex = self._execute_workflow("examples.orquesta-fail-start-task")
         ex = self._wait_for_completion(ex)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
+
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
         self.assertDictEqual(ex.result, {"errors": expected_errors, "output": None})
 
@@ -149,6 +161,9 @@ def test_task_transition_error(self):
 
         ex = self._execute_workflow("examples.orquesta-fail-task-transition")
         ex = self._wait_for_completion(ex)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
+
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
         self.assertDictEqual(
             ex.result, {"errors": expected_errors, "output": expected_output}
@@ -172,6 +187,8 @@ def test_task_publish_error(self):
 
         ex = self._execute_workflow("examples.orquesta-fail-task-publish")
         ex = self._wait_for_completion(ex)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
         self.assertDictEqual(
             ex.result, {"errors": expected_errors, "output": expected_output}
@@ -191,6 +208,8 @@ def test_output_error(self):
 
         ex = self._execute_workflow("examples.orquesta-fail-output-rendering")
         ex = self._wait_for_completion(ex)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
         self.assertDictEqual(ex.result, {"errors": expected_errors, "output": None})
 
@@ -228,6 +247,9 @@ def test_task_content_errors(self):
 
         ex = self._execute_workflow("examples.orquesta-fail-inspection-task-contents")
         ex = self._wait_for_completion(ex)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
+
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
         self.assertDictEqual(ex.result, {"errors": expected_errors, "output": None})
 
@@ -264,6 +286,8 @@ def test_remediate_then_fail(self):
 
         self._wait_for_task(ex, "task1", ac_const.LIVEACTION_STATUS_FAILED)
         self._wait_for_task(ex, "log", ac_const.LIVEACTION_STATUS_SUCCEEDED)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
 
         # Assert workflow status and result.
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
@@ -301,6 +325,8 @@ def test_fail_manually(self):
         # Assert task status.
         self._wait_for_task(ex, "task1", ac_const.LIVEACTION_STATUS_FAILED)
         self._wait_for_task(ex, "task3", ac_const.LIVEACTION_STATUS_SUCCEEDED)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
 
         # Assert workflow status and result.
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)
@@ -334,6 +360,8 @@ def test_fail_continue(self):
 
         # Assert task status.
         self._wait_for_task(ex, "task1", ac_const.LIVEACTION_STATUS_FAILED)
+        for i in ex.result["errors"]:
+            i.pop("traceback")
 
         # Assert workflow status and result.
         self.assertEqual(ex.status, ac_const.LIVEACTION_STATUS_FAILED)