Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace_bomberman_with_pokemon #125

Merged
merged 2 commits into from
Jul 10, 2024
Merged

replace_bomberman_with_pokemon #125

merged 2 commits into from
Jul 10, 2024

Conversation

Sherif-Zaki
Copy link
Contributor

Type of Change

PKM-249

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@Sherif-Zaki Sherif-Zaki requested review from a team July 1, 2024 19:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sherif-Zaki
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jul 5, 2024
@github-actions
@Sherif-Zaki has signed the CLA in #125
2723d36
mirellat
mirellat reviewed Jul 10, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@Sherif-Zaki Sherif-Zaki requested a review from mirellat July 10, 2024 12:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sherif-Zaki Sherif-Zaki merged commit d9d4fa7 into main Jul 10, 2024
7 of 8 checks passed
@Sherif-Zaki Sherif-Zaki deleted the pkm-249_replace_bomberman_with_pokemon branch July 10, 2024 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mirellat mirellat mirellat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sherif-Zaki @mirellat