Upgrade to new efficient artifact actions + mac code sign identity #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSchmiedmayer
approved these changes
Feb 16, 2024
This was referenced Feb 16, 2024
Supereg
added a commit
to StanfordSpezi/.github
that referenced
this pull request
Feb 16, 2024
# Upgrade to new upload artifact versions ## ♻️ Current situation & Problem This PR upgrades the upload artifact branch in this repository. Refer to StanfordBDHG/.github#52 for more information. ## ⚙️ Release Notes * Upgraded the upload-artifact GitHub action for increased performance. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
|
Thank you @Supereg! |
1 task
Supereg
added a commit
that referenced
this pull request
Feb 24, 2024
# Upgrade artifact actions for archive and docker actions ## ♻️ Current situation & Problem We upgraded our code-coverage artifact upload and download actions to use the new `v4` version (see #52). Our xcframework creation process and docker container actions still use the old, slow v3 actions. This PR upgrades them as well. ## ⚙️ Release Notes * Increased performance for file uploads in xcframework creation ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to new efficient artifact actions + mac code sign identity
♻️ Current situation & Problem
This PR upgrades the actions to the new v4 version of the upload- and download-artifact actions. This results in a dramatic speed increase when uploading and download artifacts.
The workflow files from this PR were tested within this action run. You can compare timings to the previous run. Comparing these two examples, the coverage download takes 1s instead of 24s. Uploading takes 1s instead of 8s (for a successful run with this example project).
⚙️ Release Notes
📚 Documentation
--
✅ Testing
These changes were tested in the above linked action runs.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: