Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symlinks in XCArchives and XCFramework #55

Merged
merged 14 commits into from
Mar 7, 2024

Conversation

philippzagar
Copy link
Contributor

Preserve symlinks in XCArchives and XCFramework

♻️ Current situation & Problem

Currently, the XCArchives and XCFramework actions don't preserve symlinks, resulting in build failures for using XCFrameworks on the macOS platform.

⚙️ Release Notes

  • Preserve symlinks in XCArchives and XCFramework

📚 Documentation

✅ Testing

Tested with llama.cpp XCFramework building

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Mar 5, 2024
@philippzagar philippzagar self-assigned this Mar 5, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the issues here; I only had a few minor comments 🚀

@philippzagar philippzagar merged commit e7025f1 into main Mar 7, 2024
2 checks passed
@philippzagar philippzagar deleted the fix/xcarchive-macos branch March 7, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants