[Enhancement] add appProtocol in fe service #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandongxiao
force-pushed
the
feature/add-appProtocol-field-in-service
branch
from
5e2e041 to
5dbcbbb
Compare
kevincai
reviewed
Oct 23, 2023
| Name: sp.Name, | ||
| Port: sp.Port, | ||
| NodePort: sp.NodePort, | ||
| Protocol: corev1.ProtocolTCP, | ||
| TargetPort: intstr.FromInt(int(sp.ContainerPort)), | ||
| }) | ||
| } | ||
| if servicePort.Name == FeQueryPortName { |
There was a problem hiding this comment.
how about the webPort? does it need to add appProtocol http?
There was a problem hiding this comment.
Do not need. Istio can detect http protocol. See https://istio.io/latest/docs/ops/deployment/requirements/#server-first-protocols
There was a problem hiding this comment.
didn't see our webport related to the server-first-protocol document. HTTP protocol doesn't look like a server-first-protocol per the description in the doc.
There was a problem hiding this comment.
MySQL is a server-first-protocol, so we only need to add appProtocol to the query port, 9030.
kevincai
previously approved these changes
Oct 24, 2023
|
ci operator failure, might need take a look @yandongxiao |
…arrocks on Istio service mesh Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
feature/add-appProtocol-field-in-service
branch
from
5dbcbbb to
3241e47
Compare
kevincai
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #287