chore: fix code for bot comment

StarRocks · Jan 16, 2025 · 8dbecf5 · 8dbecf5
1 parent 518857e
commit 8dbecf5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/be/src/exprs/try_expr.cpp b/be/src/exprs/try_expr.cpp
@@ -31,10 +31,10 @@ class TryExpr final : public Expr {
 
     StatusOr<ColumnPtr> evaluate_checked(ExprContext* context, Chunk* chunk) override {
         auto&& status = _children[0]->evaluate_checked(context, chunk);
-        if (LIKELY(!status.ok())) {
-            return ColumnHelper::create_const_null_column(chunk->num_rows());
-        }
-        return status;
+    	if (LIKELY(status.ok())) {
+        	return status;
+    	}
+    	return ColumnHelper::create_const_null_column(chunk->num_rows());
     }
 
     Expr* clone(ObjectPool* pool) const override { return pool->add(new TryExpr(*this)); }

diff --git a/fe/fe-core/src/main/java/com/starrocks/analysis/TryExpr.java b/fe/fe-core/src/main/java/com/starrocks/analysis/TryExpr.java
@@ -86,7 +86,7 @@ public boolean isNullable() {
 
     @Override
     public Expr clone() {
-        return new TryExpr(this);
+        return new TryExpr(getChild(0).clone(), pos);
     }
 
     @Override

diff --git a/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/operator/scalar/TryOperator.java b/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/operator/scalar/TryOperator.java
@@ -62,12 +62,14 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object other) {
-        return this == other;
+        if (this == other) return true;
+        if (other == null || getClass() != other.getClass()) return false;
+        TryOperator that = (TryOperator) other;
+        return Objects.equals(arguments, that.arguments);
     }
 
     @Override
     public <R, C> R accept(ScalarOperatorVisitor<R, C> visitor, C context) {
-        System.out.println("================");
         return visitor.visitTryOperator(this, context);
     }