Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allow CN to run script (backport #44982) (backport #44992) #45410

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 10, 2024

Why I'm doing:

MySQL [(none)]> admin execute on 10006 'System.print(ExecEnv.get_stack_trace_for_all_threads())';
ERROR 1064 (HY000): node not found: 10006

What I'm doing:

Allow CN to run script

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #44982 done by [Mergify](https://mergify.com). ## Why I'm doing:
MySQL [(none)]> admin execute on 10006 'System.print(ExecEnv.get_stack_trace_for_all_threads())';
ERROR 1064 (HY000): node not found: 10006

What I'm doing:

Allow CN to run script

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

This is an automatic backport of pull request #44992 done by [Mergify](https://mergify.com).

Co-authored-by: Binglin Chang <[email protected]>
(cherry picked from commit 25116c9)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ExecuteScriptExecutor.java
@mergify mergify bot added the conflicts label May 10, 2024
Copy link
Contributor Author

mergify bot commented May 10, 2024

Cherry-pick of 25116c9 has failed:

On branch mergify/bp/branch-3.2/pr-44992
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit 25116c9b9d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/ExecuteScriptExecutor.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kevincai
Copy link
Contributor

wrong backport, close.

@kevincai kevincai closed this May 10, 2024
@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-44992 branch May 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants