Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix stale histogram lead to unexpected stats (backport #45614) #45646

Merged
merged 4 commits into from
May 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 15, 2024

Why I'm doing:

Column histogram may not updated after the first collection.
If use the stale histogram to estimate row number may have a risk of divide zero exception because the estimated histogram may return 0 row count(a empty bucket and empty mcv).

What I'm doing:

If the predicate range doesn't overlap with the histogram, we use the min/max value instead of histogram to estimate statistics.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #45614 done by [Mergify](https://mergify.com). ## Why I'm doing: Column histogram may not updated after the first collection. If use the stale histogram to estimate row number may have a risk of divide zero exception because the estimated histogram may return 0 row count(a empty bucket and empty mcv).

What I'm doing:

If the predicate range doesn't overlap with the histogram, we use the min/max value instead of histogram to estimate statistics.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: packy92 <[email protected]>
(cherry picked from commit 1e5626e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/BinaryPredicateStatisticCalculator.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/Histogram.java
#	fe/fe-core/src/test/resources/sql/tpch-histogram-cost/q19.sql
@mergify mergify bot added the conflicts label May 15, 2024
Copy link
Contributor Author

mergify bot commented May 15, 2024

Cherry-pick of 1e5626e has failed:

On branch mergify/bp/branch-2.5/pr-45614
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 1e5626e9b8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/statistics/HistogramStatisticsTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/BinaryPredicateStatisticCalculator.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/Histogram.java
	both modified:   fe/fe-core/src/test/resources/sql/tpch-histogram-cost/q19.sql

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented May 15, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-45614 branch May 15, 2024 05:44
@packy92 packy92 restored the mergify/bp/branch-2.5/pr-45614 branch May 15, 2024 08:05
@packy92 packy92 reopened this May 15, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 15, 2024 08:06
packy92 added 3 commits May 15, 2024 20:46
Signed-off-by: packy92 <[email protected]>
Signed-off-by: packy92 <[email protected]>
Signed-off-by: packy92 <[email protected]>
Copy link

@wanpengfei-git wanpengfei-git merged commit 2671d05 into branch-2.5 May 16, 2024
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-45614 branch May 16, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants