[BugFix] Fix decimal literal equals uncheck type #50626

Seaven · 2024-09-03T08:38:42Z

Why I'm doing:

sum(gmv * 1.00000000000): 1.00000000000 is DECIMAL64(12, 11) Literal
sum(gmv * 1.000) : 1.000 is DECIMAL32(4, 3) Literal

equals method check 1.00000000000 is same as 1.000, but the results of hashcode method is different.
In analyze, will check duplicate expression by list.contains, only use equals method, then two expression will be reduce to one, but in QueryTransform, use HashMap to find expression, it's will take can't find expression because hashcode is different.

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Signed-off-by: Seaven <[email protected]>

sonarqubecloud · 2024-09-03T08:44:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-09-03T10:09:30Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-03T10:10:04Z

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/analysis/DecimalLiteral.java	1	1	100.00%	[]

github-actions · 2024-09-03T10:10:13Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-09-04T02:46:30Z

@Mergifyio backport branch-3.3

github-actions · 2024-09-04T02:46:31Z

@Mergifyio backport branch-3.2

github-actions · 2024-09-04T02:46:32Z

@Mergifyio backport branch-3.1

github-actions · 2024-09-04T02:46:33Z

@Mergifyio backport branch-3.0

github-actions · 2024-09-04T02:46:34Z

@Mergifyio backport branch-2.5

mergify · 2024-09-04T02:46:35Z

backport branch-3.3

✅ Backports have been created

#50657 [BugFix] Fix decimal literal equals uncheck type (backport #50626) has been created for branch branch-3.3

mergify · 2024-09-04T02:46:36Z

backport branch-3.1

✅ Backports have been created

#50658 [BugFix] Fix decimal literal equals uncheck type (backport #50626) has been created for branch branch-3.1 but encountered conflicts

mergify · 2024-09-04T02:46:40Z

backport branch-3.2

✅ Backports have been created

#50659 [BugFix] Fix decimal literal equals uncheck type (backport #50626) has been created for branch branch-3.2 but encountered conflicts

mergify · 2024-09-04T02:46:42Z

backport branch-3.0

✅ Backports have been created

#50660 [BugFix] Fix decimal literal equals uncheck type (backport #50626) has been created for branch branch-3.0 but encountered conflicts

mergify · 2024-09-04T02:46:43Z

backport branch-2.5

✅ Backports have been created

#50661 [BugFix] Fix decimal literal equals uncheck type (backport #50626) has been created for branch branch-2.5 but encountered conflicts

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/sql/plan/DecimalTypeTest.java

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/analysis/DecimalLiteral.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/DecimalTypeTest.java

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

…50661) Co-authored-by: Seaven <[email protected]>

…50658) Co-authored-by: Seaven <[email protected]>

…50660) Co-authored-by: Seaven <[email protected]>

…50657) Co-authored-by: Seaven <[email protected]>

…50626) (StarRocks#50657) Co-authored-by: Seaven <[email protected]>

…50659) Co-authored-by: Seaven <[email protected]>

Signed-off-by: Seaven <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

[BugFix] Fix decimal literal equals uncheck type

a96a716

Signed-off-by: Seaven <[email protected]>

Seaven requested a review from a team as a code owner September 3, 2024 08:38

mergify bot assigned Seaven Sep 3, 2024

Youngwb approved these changes Sep 3, 2024

View reviewed changes

github-actions bot added 3.3 3.2 3.1 3.0 2.5 labels Sep 3, 2024

packy92 approved these changes Sep 4, 2024

View reviewed changes

packy92 merged commit b95c6ee into StarRocks:main Sep 4, 2024
63 of 68 checks passed

github-actions bot removed the 3.3 label Sep 4, 2024

github-actions bot removed the 3.2 label Sep 4, 2024

github-actions bot removed the 3.1 label Sep 4, 2024

github-actions bot removed the 3.0 label Sep 4, 2024

github-actions bot removed the 2.5 label Sep 4, 2024

mergify bot pushed a commit that referenced this pull request Sep 4, 2024

[BugFix] Fix decimal literal equals uncheck type (#50626)

97c8343

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

mergify bot mentioned this pull request Sep 4, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) #50657

Merged

42 tasks

This was referenced Sep 4, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) #50658

Merged

[BugFix] Fix decimal literal equals uncheck type (backport #50626) #50659

Merged

github-actions bot added 3.3 3.2 3.1 3.0 2.5 labels Sep 4, 2024

This was referenced Sep 4, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) #50660

Merged

[BugFix] Fix decimal literal equals uncheck type (backport #50626) #50661

Merged

Seaven added a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (#50626)

15c81cf

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

Seaven added a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (#50626)

7affb18

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

Seaven added a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (#50626)

5a9612f

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

Seaven added a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (#50626)

2cad0a2

Signed-off-by: Seaven <[email protected]> (cherry picked from commit b95c6ee)

wanpengfei-git pushed a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) (#…

7209a49

…50661) Co-authored-by: Seaven <[email protected]>

github-actions bot added the 2.5-merged label Sep 6, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) (#…

d15718d

…50658) Co-authored-by: Seaven <[email protected]>

github-actions bot added the 3.1-merged label Sep 6, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) (#…

8b6f268

…50660) Co-authored-by: Seaven <[email protected]>

github-actions bot added the 3.0-merged label Sep 6, 2024

wanpengfei-git pushed a commit that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) (#…

dade530

…50657) Co-authored-by: Seaven <[email protected]>

github-actions bot added the 3.3-merged label Sep 6, 2024

xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request Sep 6, 2024

[BugFix] Fix decimal literal equals uncheck type (backport StarRocks#…

b79eefd

…50626) (StarRocks#50657) Co-authored-by: Seaven <[email protected]>

Seaven added a commit that referenced this pull request Sep 27, 2024

[BugFix] Fix decimal literal equals uncheck type (backport #50626) (#…

0ca04fe

…50659) Co-authored-by: Seaven <[email protected]>

github-actions bot added the 3.2-merged label Sep 27, 2024

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024

[BugFix] Fix decimal literal equals uncheck type (StarRocks#50626)

92571bc

Signed-off-by: Seaven <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] Fix decimal literal equals uncheck type #50626

[BugFix] Fix decimal literal equals uncheck type #50626

Seaven commented Sep 3, 2024 •

edited

Loading

sonarqubecloud bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

[BugFix] Fix decimal literal equals uncheck type #50626

[BugFix] Fix decimal literal equals uncheck type #50626

Conversation

Seaven commented Sep 3, 2024 • edited Loading

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

sonarqubecloud bot commented Sep 3, 2024

Quality Gate passed

github-actions bot commented Sep 3, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Sep 3, 2024

[FE Incremental Coverage Report]

file detail

github-actions bot commented Sep 3, 2024

[BE Incremental Coverage Report]

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

mergify bot commented Sep 4, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 4, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 4, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 4, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Sep 4, 2024 • edited Loading

✅ Backports have been created

Seaven commented Sep 3, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading

mergify bot commented Sep 4, 2024 •

edited

Loading