Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] MaxBy/MinBy not filter nulls (backport #51354) #51508

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 27, 2024

Why I'm doing:

max_by/min_by should not filter nulls, for an example:

  1. prepare data
create table test_table (
   `id` int NOT NULL,
   `name` varchar(10) DEFAULT NULL,
   `grade` int NOT NULL
) ENGINE=OLAP
PRIMARY KEY(`id`)
DISTRIBUTED BY HASH(`id`);

insert into test_table values (1,'john',90);
insert into test_table values (2,'jim',95);
insert into test_table values (3,NULL,100);

  1. query Expected outcome 'null' actual outcome 'jim'
select max_by(name, grade) from test_table;

What I'm doing:

  1. max_by and min_by not filter nulls;
  2. fix ancient bug: crash caused by window query like max_by(T, S) over window_def when S's type is not same to T's

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #51354 done by [Mergify](https://mergify.com). ## Why I'm doing:

max_by/min_by should not filter nulls, for an example:

  1. prepare data
create table test_table (
   `id` int NOT NULL,
   `name` varchar(10) DEFAULT NULL,
   `grade` int NOT NULL
) ENGINE=OLAP
PRIMARY KEY(`id`)
DISTRIBUTED BY HASH(`id`);

insert into test_table values (1,'john',90);
insert into test_table values (2,'jim',95);
insert into test_table values (3,NULL,100);

  1. query Expected outcome 'null' actual outcome 'jim'
select max_by(name, grade) from test_table;

What I'm doing:

  1. max_by and min_by not filter nulls;
  2. fix ancient bug: crash caused by window query like max_by(T, S) over window_def when S's type is not same to T's

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: satanson <[email protected]>
(cherry picked from commit 9398edd)

# Conflicts:
#	be/src/exec/analytor.cpp
#	be/src/exprs/agg/factory/aggregate_factory.cpp
#	be/src/exprs/agg/factory/aggregate_factory.hpp
#	be/src/exprs/agg/factory/aggregate_resolver_minmaxany.cpp
#	be/src/exprs/agg/maxmin_by.h
#	be/test/exprs/agg/aggregate_test.cpp
#	fe/fe-core/src/main/java/com/starrocks/analysis/FunctionName.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/Function.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/FunctionSet.java
#	fe/fe-core/src/main/java/com/starrocks/catalog/combinator/AggStateDesc.java
#	test/sql/test_agg_state/R/test_agg_state_table_with_all_functions.sql
@mergify mergify bot added the conflicts label Sep 27, 2024
Copy link
Contributor Author

mergify bot commented Sep 27, 2024

Cherry-pick of 9398edd has failed:

On branch mergify/bp/branch-2.5/pr-51354
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 9398edd4af.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   test/sql/test_max_min_by_not_filter_nulls_with_nulls/R/test_max_min_by_not_filter_nulls_with_nulls
	new file:   test/sql/test_max_min_by_not_filter_nulls_with_nulls/T/test_max_min_by_not_filter_nulls_with_nulls
	new file:   test/sql/test_max_min_by_not_filter_nulls_without_nulls/R/test_max_min_by_not_filter_nulls_without_nulls
	new file:   test/sql/test_max_min_by_not_filter_nulls_without_nulls/T/test_max_min_by_not_filter_nulls_without_nulls

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   be/src/exec/analytor.cpp
	both modified:   be/src/exprs/agg/factory/aggregate_factory.cpp
	both modified:   be/src/exprs/agg/factory/aggregate_factory.hpp
	both modified:   be/src/exprs/agg/factory/aggregate_resolver_minmaxany.cpp
	both modified:   be/src/exprs/agg/maxmin_by.h
	both modified:   be/test/exprs/agg/aggregate_test.cpp
	both modified:   fe/fe-core/src/main/java/com/starrocks/analysis/FunctionName.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/Function.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/FunctionSet.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/catalog/combinator/AggStateDesc.java
	deleted by us:   test/sql/test_agg_state/R/test_agg_state_table_with_all_functions.sql

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Sep 27, 2024
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 27, 2024 09:09
@mergify mergify bot closed this Sep 27, 2024
auto-merge was automatically disabled September 27, 2024 09:09

Pull request was closed

Copy link
Contributor Author

mergify bot commented Sep 27, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant