-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]Lock account for timeout duration after failed login attempts #51948
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
@mergify rebase |
…empts Signed-off-by: Rohit Satardekar <[email protected]>
✅ Branch has been successfully rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitrs1983 what if the user account get locked and then never attempted for a long time. The failed record is not cleaned. May need to add periodic task to clean expired locks.
…empts Signed-off-by: Rohit Satardekar <[email protected]>
@kevincai have fix the issue. i have added the cleanup mechanism as part of password validation process with a default cleanup timeout is 24h. |
Quality Gate passedIssues Measures |
fe/fe-core/src/main/java/com/starrocks/authentication/AuthenticationMgr.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/authentication/AuthenticationMgr.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/authentication/AuthenticationMgr.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/authentication/AuthenticationMgr.java
Show resolved
Hide resolved
…empts Signed-off-by: Rohit Satardekar <[email protected]>
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Lock account for timeout duration after failed login attempts
Why I'm doing:
What I'm doing:
Fixes #51917
$ mysql -h127.0.0.1 -P9030 -u jack -p
Enter password:
ERROR 1045 (28000): Access denied for user 'jack' (using password: YES)
$ mysql -h127.0.0.1 -P9030 -u jack -p
Enter password:
ERROR 1045 (28000): Access denied for user 'jack' (using password: YES)
$ mysql -h127.0.0.1 -P9030 -u jack -p
Enter password:
ERROR 5204 (HY000): Access denied for user 'jack'@'127.0.0.1'. Account is temporarily locked due to 3 consecutive failed logins.
$ mysql -h127.0.0.1 -P9030 -u jack -p
Enter password:
ERROR 5204 (HY000): Access denied for user 'jack'@'127.0.0.1'. Account is temporarily locked due to 3 consecutive failed logins.
$ mysql -h127.0.0.1 -P9030 -u jack -p
Enter password:
mysql>
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: