Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize merge commit sync mode #54676

Closed
wants to merge 6 commits into from

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented Jan 3, 2025

Why I'm doing:

What I'm doing:

There will be more optimization

  1. BE will poll the txn status periodically to avoid the FE send failure such as FE leader changes, or reach the max retry time
  2. set an expire time for an idle txn status entry (no waiters)

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@mergify mergify bot assigned banmoy Jan 3, 2025
@banmoy banmoy marked this pull request as draft January 8, 2025 09:22
@banmoy banmoy force-pushed the push_label_34 branch 2 times, most recently from fd3f2d2 to f175e01 Compare January 9, 2025 13:04
@banmoy banmoy marked this pull request as ready for review January 11, 2025 16:44
@banmoy banmoy changed the title [Enhancement][WIP] Optimize merge commit sync mode [Enhancement] Optimize merge commit sync mode Jan 11, 2025
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
@banmoy banmoy changed the base branch from branch-3.4 to main January 12, 2025 02:14
@banmoy banmoy requested review from a team as code owners January 12, 2025 02:14
Signed-off-by: PengFei Li <[email protected]>
@wanpengfei-git wanpengfei-git requested a review from a team January 12, 2025 02:17
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[BE Incremental Coverage Report]

pass : 359 / 431 (83.29%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/batch_write/batch_write_mgr.h 0 1 00.00% [53]
🔵 be/src/service/internal_service.cpp 0 6 00.00% [1282, 1283, 1286, 1290, 1291, 1292]
🔵 be/src/http/action/update_config_action.cpp 1 6 16.67% [333, 334, 335, 336, 338]
🔵 be/src/runtime/batch_write/isomorphic_batch_write.cpp 21 30 70.00% [426, 427, 434, 435, 436, 439, 440, 441, 453]
🔵 be/src/runtime/batch_write/txn_state_cache.h 16 22 72.73% [44, 45, 46, 130, 131, 132]
🔵 be/src/util/dynamic_cache.h 23 27 85.19% [306, 321, 342, 344]
🔵 be/src/runtime/batch_write/batch_write_mgr.cpp 25 29 86.21% [270, 271, 272, 275]
🔵 be/src/runtime/batch_write/txn_state_cache.cpp 271 308 87.99% [36, 52, 100, 105, 114, 122, 128, 129, 130, 132, 133, 134, 139, 140, 171, 172, 216, 220, 267, 268, 269, 275, 276, 281, 282, 310, 311, 315, 316, 334, 384, 394, 452, 453, 454, 455, 461]
🔵 be/src/runtime/exec_env.cpp 2 2 100.00% []

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 149 / 165 (90.30%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/TransactionStatus.java 2 8 25.00% [75, 78, 81, 87, 90, 92]
🔵 com/starrocks/load/batchwrite/IsomorphicBatchWrite.java 10 13 76.92% [271, 272, 273]
🔵 com/starrocks/load/batchwrite/TxnStateDispatcher.java 131 138 94.93% [64, 85, 86, 118, 119, 198, 201]
🔵 com/starrocks/common/Config.java 2 2 100.00% []
🔵 com/starrocks/load/batchwrite/BatchWriteMgr.java 1 1 100.00% []
🔵 com/starrocks/load/batchwrite/LoadExecutor.java 3 3 100.00% []

@banmoy banmoy marked this pull request as draft January 13, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants