Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] parquet writer do not perform time zone adjustments when writing timestamp types. #55194

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Jan 17, 2025

Why I'm doing:

datetime map to timestamp without timezone when create iceberg table, but parquet writer perform time zone adjustment when writing timestamp type, this should be consistent here.

Fixes #55065

What I'm doing:

parquet writer do not perform time zone adjustment when writing timestamp type,

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Youngwb Youngwb requested a review from a team as a code owner January 17, 2025 05:20
Signed-off-by: Youngwb <[email protected]>
@Youngwb Youngwb changed the title [BugFix] parquet writer do not perform time zone adjustments when writing datetime types. [BugFix] parquet writer do not perform time zone adjustments when writing timestamp types. Jan 17, 2025
Signed-off-by: Youngwb <[email protected]>
Signed-off-by: Youngwb <[email protected]>
Signed-off-by: Youngwb <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/parquet_file_writer.cpp 1 1 100.00% []
🔵 be/src/formats/parquet/level_builder.cpp 3 3 100.00% []
🔵 be/src/formats/parquet/file_writer.cpp 1 1 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant