[BugFix] fix ingestion hang because of alter job timeout (backport #55207) #55236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In shared-data cluster, alter job will increase partition's next version and then change state to
FINISHED_REWRITING
. But if this alter job is timeout, it won't be executed and can't finish, it will lead to version gap and cause issue like:What I'm doing:
Two changes in my PR:
This pull request includes changes to improve the handling of job cancellation and timeouts in the
AlterJobV2
class, as well as a minor adjustment to the timeout parameter in theSchemaChangeHandler
class. The most important changes are summarized below:Improvements to job cancellation handling:
fe/fe-core/src/main/java/com/starrocks/alter/AlterJobV2.java
: Modified therun
method to handle job cancellation more effectively by checking if the job can be cancelled and executing it if not.Adjustments to timeout parameter:
fe/fe-core/src/main/java/com/starrocks/alter/SchemaChangeHandler.java
: Changed the timeout parameter forLakeTableAlterMetaJob
from seconds to milliseconds to ensure accurate timeout handling.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: