Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Re-add support for SQLAlchemy 1.4 #55435

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[Enhancement] Re-add support for SQLAlchemy 1.4 #55435

merged 1 commit into from
Jan 28, 2025

Conversation

maver1ck
Copy link
Contributor

@maver1ck maver1ck commented Jan 24, 2025 •
edited by Astralidea
Loading

Why I'm doing:

Changing SQLAlchemy version from >=2.0 to >=1.4

What I'm doing:

Fixes #55434

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Astralidea Astralidea enabled auto-merge (squash) January 26, 2025 02:48
@Astralidea Astralidea changed the title Re-add support for SQLAlchemy 1.4 [Enhancement] Re-add support for SQLAlchemy 1.4 Jan 26, 2025
@Astralidea
Copy link
Contributor

Please sign off the commit. Thanks

@github-actions github-actions bot added the 3.4 label Jan 27, 2025
@maver1ck
Readd support for SQLAlchemy 1.4
86f84b1 
Signed-off-by: Maciek Bryński <[email protected]>
auto-merge was automatically disabled January 27, 2025 10:23

Head branch was pushed to by a user without write access

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@maver1ck
Copy link
Contributor Author

Please sign off the commit. Thanks

Done

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@alvin-celerdata alvin-celerdata merged commit 7f7ac0d into StarRocks:main Jan 28, 2025
42 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 28, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 28, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 28, 2025
@maver1ck @mergify
[Enhancement] Re-add support for SQLAlchemy 1.4 (#55435)
6afea90 
Changing SQLAlchemy version from >=2.0 to >=1.4

Signed-off-by: Maciek Bryński <[email protected]>
(cherry picked from commit 7f7ac0d)
@mergify mergify bot mentioned this pull request Jan 28, 2025
Closed
18 tasks
@maver1ck
Copy link
Contributor Author

@Astralidea
Can we release version 1.2.1 of this package to PyPi ?

@chenlb
Copy link

chenlb commented Feb 19, 2025

@Astralidea Can we release version 1.2.1 of this package to PyPi ?

in BI_integrations Apache Superset case, also need SQLAlchemy 1.4

@Astralidea
Copy link
Contributor

I will release version 1.2.1 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astralidea Astralidea Astralidea approved these changes

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

Assignees

@maver1ck maver1ck

Labels
behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starrocks + Datahub integration
4 participants
@maver1ck @Astralidea @chenlb @alvin-celerdata