Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for remote attaching to container #2732

Merged
merged 18 commits into from
Sep 20, 2024
Merged

add support for remote attaching to container #2732

merged 18 commits into from
Sep 20, 2024

Conversation

dr-bonez
Copy link
Member

TODO:

  • indicate options if multiple subcontainers
  • allow specifying which subcontainer if multiple
  • use default shell if no command provided

@dr-bonez dr-bonez marked this pull request as ready for review September 11, 2024 17:38
@dr-bonez
Copy link
Member Author

TODOs are handled. tty support is still not great, ideally should be fixed in a future pr

@dr-bonez dr-bonez merged commit eec5cf6 into next/minor Sep 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blu-J Blu-J Blu-J approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dr-bonez @Blu-J