Upgrade angular version v12 to v17 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 3, 2024 19:04
...ubeflow-common-lib/projects/kubeflow/src/lib/form/rok-url-input/rok-url-input.component.scss
Outdated
Show resolved
Hide resolved
...projects/kubeflow/src/lib/form/name-namespace-inputs/name-input/name-input.component.spec.ts
Show resolved
Hide resolved
frontend/common/kubeflow-common-lib/projects/kubeflow/src/styles.scss
Outdated
Show resolved
Hide resolved
added 13 commits
January 18, 2024 20:24
Souheil-Yazji
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
gonna assume this looks more aesthetic now ;)
There was a problem hiding this comment.
it was looking a bit wonky, inputs were too close to each other, plus now we actually display the size of the existing volumes since i fixed that code,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #307 (and jira https://jirab.statcan.ca/browse/BTIS-79 which includes the subtasks)
FYI Node version 18 is needed instead of 16 like it used to be, since we are more modern now.