Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Dockle with hadolint #325

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Replaced Dockle with hadolint #325

merged 5 commits into from
Jul 3, 2024

Conversation

mathis-marcotte
Copy link
Contributor

wg102
wg102 reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@wg102 wg102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we now hadolint before local build?

@mathis-marcotte
Copy link
Contributor Author

Following how it's done in kubeflow-containers. Makes a lot more sense to lint the dockerfile before building it if there are serious issues in there.

@mathis-marcotte mathis-marcotte merged commit b1de170 into main Jul 3, 2024
7 checks passed
@mathis-marcotte mathis-marcotte deleted the replace-dockle-with-hadolint branch July 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wg102 wg102 wg102 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathis-marcotte @wg102