fix asc/desc in dropdown

SteamDeckHomebrew · Dec 19, 2023 · b76256a · b76256a
1 parent e56fcbf
commit b76256a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/backend/locales/en-US.json b/backend/locales/en-US.json
@@ -218,10 +218,10 @@
       "about": "About",
       "alph_asce": "Alphabetical (Z to A)",
       "alph_desc": "Alphabetical (A to Z)",
-      "date_asce": "Oldest first",
-      "date_desc": "Newest first",
-      "downloads_asce": "Most Downloaded",
-      "downloads_desc": "Least Downloaded",
+      "date_asce": "Newest First",
+      "date_desc": "Oldest First",
+      "downloads_asce": "Most Downloaded First",
+      "downloads_desc": "Least Downloaded First",
       "title": "Browse"
     },
     "store_testing_cta": "Please consider testing new plugins to help the Decky Loader team!",

diff --git a/frontend/src/components/store/Store.tsx b/frontend/src/components/store/Store.tsx
@@ -66,12 +66,15 @@ const BrowseTab: FC<{ children: { setPluginCount: Dispatch<SetStateAction<number
 
   const dropdownSortOptions = useMemo(
     (): DropdownOption[] => [
-      { data: [SortOptions.name, SortDirections.descending], label: t('Store.store_tabs.alph_desc') },
-      { data: [SortOptions.name, SortDirections.ascending], label: t('Store.store_tabs.alph_asce') },
-      { data: [SortOptions.date, SortDirections.descending], label: t('Store.store_tabs.date_desc') },
+      // ascending and descending order are the wrong way around for the alphabetical sort
+      // this is because it was initially done incorrectly for i18n and 'fixing' it would
+      // make all the translations incorrect
+      { data: [SortOptions.name, SortDirections.ascending], label: t('Store.store_tabs.alph_desc') },
+      { data: [SortOptions.name, SortDirections.descending], label: t('Store.store_tabs.alph_asce') },
       { data: [SortOptions.date, SortDirections.ascending], label: t('Store.store_tabs.date_asce') },
-      { data: [SortOptions.downloads, SortDirections.descending], label: t('Store.store_tabs.downloads_desc') },
+      { data: [SortOptions.date, SortDirections.descending], label: t('Store.store_tabs.date_desc') },
       { data: [SortOptions.downloads, SortDirections.ascending], label: t('Store.store_tabs.downloads_asce') },
+      { data: [SortOptions.downloads, SortDirections.descending], label: t('Store.store_tabs.downloads_desc') },
     ],
     [],
   );