Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include correct indi headers #4025

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

DarthGandalf
Copy link
Contributor

For the hacky non-installed case, provide dummy headers which redirect to their actual locations. I hope this whole case can be removed soon...

Description

Fix #4019

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

The Gentoo package builds with this patch; for the non-installed hack, I hope the CI will catch it.

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For the hacky non-installed case, provide dummy headers which redirect
to their actual locations. I hope this whole case can be removed soon...

Fix Stellarium#4019
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w added this to the 25.1 milestone Dec 25, 2024
@alex-w alex-w merged commit af0421c into Stellarium:master Dec 25, 2024
15 checks passed
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 29, 2024
Copy link

Hello @DarthGandalf!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: published The fix has been published for testing in weekly binary package
Development

Successfully merging this pull request may close these issues.

fatal error: libs/indiclient/baseclient.h: No such file or directory
2 participants