-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modelling motions of binary star system #4095
base: master
Are you sure you want to change the base?
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Great stuff! But probably #4076 should be 100% fixed before adding this. γ Vir is another nice double. For a catalog, this looks promising: http://www.astro.gsu.edu/wds/orb6.html |
Damn, I don't have access to WDS catalog anymore O_o Yes, adding full support WDS catalog is possible now and probably it should be adding via 2 files - one file for known orbital elements of binaries (multiple systems) and one file for cross identification and informational data (likewise a currect HIP subset of WDS). |
Thanks for noticing the inconsistency! Motion of the barycenter is taken into account already but a problem on normalized vector caused the error in position. Now I have fixed the issue and added γ Vir. |
I've seen some stars that should be modelled as double stars (I'm not sure if they have defined orbits, though). I simply based this on looking at what stars fly apart in the future or past.
|
I have fixed the parameters so 61 Cyg should match the HiPS layer now.
Thanks for the list.
|
Would it be possible to visualize the orbit, just like planet orbits? And maybe even have markers on it (point of visual/actual apo-/periastron, perhaps markings for dates)? |
This is maybe helpful:
Maybe adding some catalog of orbital data will be good solution (reading data from this catalog and use it for computations)? |
I have added support to model motions of binary star system as seen on the sky and their 6D astrometry (RA, DEC, PMRA, PMDEC, PLX, RV).
So far I have only manually added Alpha Centauri A/B, Sirius A/B and 61 Cygni A/B. In order to model a binary system we need:
At least for Alpha Centauri A/B and Sirius A/B, the motion on the sky as well as radial velocity matched really well to past observations (https://iopscience.iop.org/article/10.3847/1538-3881/abfaff/pdf, https://arxiv.org/pdf/1703.10625).
If there are other binary systems you want to model, I can try to find all the required orbital parameters and add them manually before we figure it out a way to model a large amount of binary stars if possible.
Fixes #353
Screenshots (if appropriate):
An example of Sirius A/B with parallax disabled to avoid confusion:
Untitled.mov
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: