Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hips_frame and type to determine planet #4170

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented Mar 2, 2025

Description

The current way of determining planet—by reading the filename of survey's URL—is quite hacky and doesn't let one find other survey components related to the same planet, e.g. the normal map. At the same time, all the planet HiPS currently available have properties that determine them as planetary, which planet they are for, and what type of map they represent.

So this PR uses these properties to determine planet.

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Mar 2, 2025

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@@ -61,7 +61,7 @@ class HipsSurvey : public QObject
//! Create a new HipsSurvey from its url.
//! @param url The location of the survey.
//! @param releaseDate If known the UTC JD release date of the survey. Used for cache busting.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param type must be explained here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@alex-w alex-w added this to the 25.1 milestone Mar 2, 2025
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@10110111 10110111 merged commit d5a326b into master Mar 3, 2025
27 of 29 checks passed
@10110111 10110111 deleted the hips-planet-name branch March 3, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants