Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types fixes 2 #573

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Types fixes 2 #573

merged 7 commits into from
Oct 20, 2024

Conversation

StoneCypher
Copy link
Owner

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling cbb3d68 on types-fixes-2
into 1241e0f on main.

@StoneCypher StoneCypher merged commit ffd807a into main Oct 20, 2024
26 checks passed
@StoneCypher
Copy link
Owner Author

I'm sorry this took me so long. (Listen to this blues song about my life)

Thank you for this generous donation, @tylerbutler

@StoneCypher
Copy link
Owner Author

Released as 5.100.0. There's a 5.101 inbound on some library bumps

@tylerbutler
Copy link
Contributor

I'm sorry this took me so long. (Listen to this blues song about my life)

Thank you for this generous donation, @tylerbutler

Thanks a lot for merging this! The new release of jssm seems to work for us.

While upgrading, I noticed that jssm-viz is exhibiting a similar problem - I addressed it in a similar way to my changes here, and the patched version works in our repo. I will open a PR against jssm-viz shortly for you to take a look.

@tylerbutler
Copy link
Contributor

I will open a PR against jssm-viz shortly for you to take a look.

@StoneCypher The PR I mentioned: StoneCypher/jssm-viz#54

@tylerbutler
Copy link
Contributor

@StoneCypher Also, I want to apologize for the "meaningless" commits in this PR. I was operating in "squash merge" mode and did not clean up the commit history like I should have for a standard merge. Sorry for the clutter.

@StoneCypher
Copy link
Owner Author

I actually prefer unsquashed

Thank you for the donations

@tylerbutler
Copy link
Contributor

Thank you for the donations

You're welcome. Happy to contribute. :) Thanks for the great library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants