-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types fixes 2 #573
Types fixes 2 #573
Conversation
…; bump version, rebuild, release
I'm sorry this took me so long. (Listen to this blues song about my life) Thank you for this generous donation, @tylerbutler |
Released as |
Thanks a lot for merging this! The new release of jssm seems to work for us. While upgrading, I noticed that jssm-viz is exhibiting a similar problem - I addressed it in a similar way to my changes here, and the patched version works in our repo. I will open a PR against jssm-viz shortly for you to take a look. |
@StoneCypher The PR I mentioned: StoneCypher/jssm-viz#54 |
@StoneCypher Also, I want to apologize for the "meaningless" commits in this PR. I was operating in "squash merge" mode and did not clean up the commit history like I should have for a standard merge. Sorry for the clutter. |
I actually prefer unsquashed Thank you for the donations |
You're welcome. Happy to contribute. :) Thanks for the great library. |
No description provided.