Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create route tab component #110

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Conversation

JSH99
Copy link
Member

@JSH99 JSH99 commented Jan 16, 2024

개요

여행 스페이스 일정 탭 컴포넌트 구현
close #93

스크린샷

주요 내용

  • day별 장소 카드 마크업
  • 지도에 동선 표시

고민한 점, 질문거리

다른 곳에서는 잘 나오는데 원래 위치인 tab panel 내부에 컴포넌트를 넣으면 지도가 저렇게 나옵니다..
style 충돌인 것은 확인했는데 우선 해결해보다가 안 되면 다른 파트 개발하다가 멘토링 때 질문해보려고 합니다.
위에 스크린샷에 제대로 나온 것처럼 보이는 것은 새로고침 30번 정도 하면 가끔 정상적으로 나오는데 그때 캡쳐해두었습니다..
현재 이미지처럼 지도 제대로 뜨지 않고 있습니다 🥲

@JSH99 JSH99 added the feat label Jan 16, 2024
@JSH99 JSH99 self-assigned this Jan 16, 2024
@JSH99 JSH99 linked an issue Jan 16, 2024 that may be closed by this pull request
3 tasks
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
trip-vote-fe ✅ Ready (Inspect) Visit Preview Jan 16, 2024 3:54pm

Copy link
Contributor

@SKY-PEY SKY-PEY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 style 때문에 지도까지 어그러지는거 너무 머리 아프네요😥 너무 고생 많으셨습니다!

Copy link
Member

@Yamyam-code Yamyam-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오! 여행탭 지도도 구현이 되었군요 ㅎㅎ 지도 크기는 다음에 함께 수정해봅시다!!!

Copy link
Contributor

@JeongMin83 JeongMin83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 첫 사진 보고 해결하신 줄 알았는데 아니었네요 ㅠㅠ
완성이 기대되는 페이지입니다

@HOOOO98 HOOOO98 merged commit e09e71e into dev Jan 17, 2024
3 checks passed
@HOOOO98 HOOOO98 deleted the 93-feat-create-route-tab-component branch January 17, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat : create route tab component
6 participants