Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: create search page #58

Merged
merged 166 commits into from
Jan 10, 2024
Merged

Feat: create search page #58

merged 166 commits into from
Jan 10, 2024

Conversation

Yamyam-code
Copy link
Member

@Yamyam-code Yamyam-code commented Jan 10, 2024 •
edited
Loading

개요

홈페이지에서 이동할 수 있는 검색 페이지 및 검색 결과 페이지 마크업
close #41

스크린샷

이미지1의_대체_텍스트 이미지2의_대체_텍스트

주요 내용

  • 검색 페이지 마크업
  • 검색 결과 페이지 마크업
  • 슬라이드 버튼 사이즈 조절 속성 추가

고민한 점, 질문거리

  • 슬라이드 버튼 컴포넌트 사용 시 선택적으로 buttonSize = {number}를 부여하면 사이즈 조절 가능
    미 입력 시 default 40

  • 현재 임시로 검색 키워드 상태로 보관 중이나 이후에 어떻게 할 것인지 결정 후 바꿀 예정

  • --allow-unrelated-histories 사용으로 dev와 브랜치를 다시 붙여놨습니다. 다른 분들 제 pr 머지된 후 자동 머지 되는지 체크 해보시길 바라요

HOOOO98 and others added 30 commits December 26, 2023 20:28
@HOOOO98
Initial commit
ea12df8
@HOOOO98
Conf: initial settings
ea2d1ea
@HOOOO98
Conf: initial settings
f11dbcb
@HOOOO98
Conf: initial settings
7f381f3
@Yamyam-code
Conf: set absolute path
77c04f4
@JeongMin83
Conf: set route container
ad46f8e
@HOOOO98
Conf: remove unused import module
e40bb9f
@JeongMin83
Update issue templates
b466b8e
@JeongMin83
Create pull_request_template.md
aaf8e79
@HOOOO98
Conf: rename sevice
0508fd6
@HOOOO98
Conf: initial settings
e7ccc85
@JeongMin83
conf: set global style
4cd42b7
@JeongMin83
conf: change typography mixin
8a04aa7
@JeongMin83
conf: add absolute direction
63e3389
@JeongMin83
fix: vercel error
9045ab6
@JeongMin83
Merge pull request #3 from Strong-Potato/2-conf-set-global-style
a8944dc 
conf: set global style
@JeongMin83
feat: create GNB
2d2794d
@JeongMin83
Refactor: edit code
66319cf
@JeongMin83
refactor: edit scss root
38f8499
@JeongMin83
Merge pull request #5 from Strong-Potato/1-feat-create-gnb
f03cd9d 
feat: create GNB
@HOOOO98
Conf: add github actions #8
de24b4a
@Yamyam-code
Fix: edit typography
7835264
@Yamyam-code
Feat: voteathome markup
cc41f3e
@HOOOO98
Merge pull request #9 from Strong-Potato/8-conf-add-github-actions
c978845 
Conf: add github actions
@Yamyam-code
Refactor: vote-at-home separate components
52e1ccb
@SKY-PEY
Feat: add voteTitleModal markup
8653207
@SKY-PEY
Style: remove comment
8390a99
@SKY-PEY
Merge branch 'dev' of https://github.com/Strong-Potato/TripVote-FE in…
a39ac79 
…to 11-feat-create-vote
@Yamyam-code
Feat: recommended-list at home markup
b068c20
@SKY-PEY
Fix: fix import error and modify position in GNB scss
937d8c9
Yamyam-code and others added 20 commits January 7, 2024 18:58
@Yamyam-code
Feat: add list slide
97efd7c
@Yamyam-code
Refactor: responsive padding cardnull
e3724b2
@Yamyam-code
Merge branch '6-feat-create-home' into 33-feat-add-list-slide
b8ee847
@Yamyam-code
Feat: link page url
feb4dab
@Yamyam-code
Merge pull request #40 from Strong-Potato/33-feat-add-list-slide
eb5326c 
Feat: add list slide
@NamgungJongMin
Refactor: seperate component's in Login.tsx
24188be
@HOOOO98
Fix: remove scrollbar in sidebar #43
ac4b9c4
@NamgungJongMin
Refactor: seperate types from components
37fbdbb
@NamgungJongMin
Merge branch 'dev' into 19-feat-create-login-page
5997870
@NamgungJongMin
Merge pull request #45 from Strong-Potato/19-feat-create-login-page
fd29d7b 
Feat: create login page
@Yamyam-code
Merge pull request #44 from Strong-Potato/43-fix-remove-scrollbar-in-…
8ee39c0 
…sidebar

Fix: remove scrollbar in sidebar #43
@Yamyam-code
Feat: add home search page hot keyword
68b4b05
@Yamyam-code
Fix: slide button bug fix
17309f9
@Yamyam-code
Feat: search page from home markup
15f5cb0
@Yamyam-code
Feat: automatically sum keywords width
7dac04b
@Yamyam-code
Feat: add search page from home
e1ad196
@Yamyam-code
Merge branch 'dev' of https://github.com/Strong-Potato/TripVote-FE in…
173da8b 
…to 41-feat-create-search-page
@Yamyam-code
Feat: home search bar add enter
719a311
@Yamyam-code
Feat: add slide button sizing feature
3ceabdf
@Yamyam-code
Fix: resolve searchBar typeError
9c6627e
@Yamyam-code Yamyam-code linked an issue Jan 10, 2024 that may be closed by this pull request
Feat: create search page #41
Closed
1 task
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
trip-vote ✅ Ready (Inspect) Visit Preview Jan 10, 2024 7:42am

@Yamyam-code Yamyam-code self-assigned this Jan 10, 2024
@Yamyam-code Yamyam-code added this to the TripVote FE development milestone Jan 10, 2024
HOOOO98
HOOOO98 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@HOOOO98 HOOOO98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

NamgungJongMin
NamgungJongMin approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@NamgungJongMin NamgungJongMin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@Yamyam-code Yamyam-code merged commit eb6df5b into dev Jan 10, 2024
3 checks passed
@Yamyam-code Yamyam-code deleted the 41-feat-create-search-page branch January 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongMin83 JeongMin83 JeongMin83 approved these changes

@NamgungJongMin NamgungJongMin NamgungJongMin approved these changes

@HOOOO98 HOOOO98 HOOOO98 approved these changes

Assignees

@Yamyam-code Yamyam-code

Labels
feat
Projects
FE Project
Status: Done
Milestone
TripVote FE development
Development

Successfully merging this pull request may close these issues.

Feat: create search page
6 participants
@Yamyam-code @JeongMin83 @NamgungJongMin @HOOOO98 @SKY-PEY @JSH99