Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: search page add map api #96

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Conversation

Yamyam-code
Copy link
Member

@Yamyam-code Yamyam-code commented Jan 14, 2024

개요

홈 검색기능에 지도를 추가했습니다!
close #78

스크린샷

이미지1의_대체_텍스트 이미지2의_대체_텍스트

주요 내용

  • 카카오 지도api를 불러와 화면에 출력합니다.
  • 카테고리 탭을 변경할 때 마다 핀 및 바운더리가 변경됩니다.
  • 리스트 슬라이드를 조작하면 현재 화면에 띄워져있는 아이템의 핀 아이콘이 변경됩니다.

고민한 점, 질문거리

  • 추후에 필요하신 분이 계시다면 공용 컴포넌트화 진행 예정
  • 모바일 스크롤 환경에서 핀 변경도 적용해놓았음
  • 모바일 환경에서 핀 변경 시 간헐적으로 핀 깜박임이 있는데 추후 수정예정 (이유는 파악해놓음)

@Yamyam-code Yamyam-code linked an issue Jan 14, 2024 that may be closed by this pull request
1 task
Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trip-vote ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 3:39pm

Copy link
Contributor

@SKY-PEY SKY-PEY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니 벌써 이걸 다 하셨다구요😮??? 진짜 빠르시네요 고생하셨습니다!!

Copy link
Contributor

@HOOOO98 HOOOO98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드보고 공부가 많이 됐습니다~고생하셨어요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복 아이콘 정리가 필요해 보이네요
은영님도 pr에도rank_1.svg파일이 있어서요ㅎㅎ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와.. 무수히 많은 시도가 엿보이는 파일이네요! 고생하셨습니다!!👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오맵은 소문자로 사용하는군요!

@Yamyam-code Yamyam-code merged commit 13b92e1 into dev Jan 15, 2024
3 checks passed
@Yamyam-code Yamyam-code deleted the 78-feat-search-page-add-map-api branch January 15, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feat: search page add map api
4 participants