Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use objects instead of managing singletons manually #190

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Aug 22, 2024

An added bonus for objects in K/JS is they are eagerly initialized, if they do not contain properties, eliminating the redundant x === VOID checks.

Originally part of #188.

@ftomassetti
Copy link
Member

Nice. By the way I guess Kotlin 2.0.20 is coming soon and soon we could release version 1.0.0

@lppedd
Copy link
Contributor Author

lppedd commented Aug 22, 2024

@ftomassetti I'll do some tests to verify 2.0.20 is compatible with 1.9.24 consumers.

In our case, I'm still holding off because of KT-66125 and KT-70533. I want to be sure we don't incur in new unexpected behaviors.

Copy link
Member

@ftomassetti ftomassetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks in order

@ftomassetti ftomassetti merged commit 7951a3f into Strumenta:master Aug 22, 2024
6 checks passed
@lppedd lppedd deleted the refactor/objects branch August 22, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants