Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle Wrapper to 8.8 #193

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Aug 24, 2024

The explicit version in build.gradle.kts has been removed as it can cause confusion when trying to update the wrapper via CLI.

@ftomassetti
Copy link
Member

The explicit version in build.gradle.kts has been removed as it can cause confusion when trying to update the wrapper via CLI.

What I typically do when I need to update the gradle wrapper is change the build.gradle.kts and run ./gradlew wrapper. I find it more convenient that having to look for the CLI command to run to do so. Would it make sense to keep the version in the build.gradle.kts and add a comment either in the build.gradle.kts or the README?

@lppedd
Copy link
Contributor Author

lppedd commented Aug 24, 2024

@ftomassetti the reasoning for that change is that I lost 20 minutes trying to understand why the .jar file wasn't getting updated, and then I recalled the version was set in the .kts file.

Typically I never remember the correct command so I refer back to the documentation: Upgrading the Gradle Wrapper.
The docs show the CLI usage, and I think 90% of people will always follow the official docs.

Btw, it's not a big deal, so in case I'll revert it.

@ftomassetti
Copy link
Member

@ftomassetti the reasoning for that change is that I lost 20 minutes trying to understand why the .jar file wasn't getting updated, and then I recalled the version was set in the .kts file.

Ok, that never happened to me, but I understand it could well happen to many others, so I think you have a point

Typically I never remember the correct command so I refer back to the documentation: Upgrading the Gradle Wrapper.
The docs show the CLI usage, and I think 90% of people will always follow the official docs.

Yes, it is jut that I always spend those 30 seconds looking for that instructions, but if it saves others from spending 20 minutes debugging this issues I think it is worth it

Btw, it's not a big deal, so in case I'll revert it.

Let's keep it as in your PR

@ftomassetti ftomassetti merged commit 7ec0ce5 into Strumenta:master Aug 26, 2024
6 checks passed
@lppedd lppedd deleted the build/gradle branch August 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants