Puppeteer core dependency #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rud
approved these changes
Feb 28, 2024
|
@rud IMHO its better to not have another config option. |
|
@abrom any update for merging this ? |
abrom
approved these changes
Mar 9, 2024
README.md
Outdated
| @@ -194,6 +194,12 @@ File.open("grover.png", "wb") { |f| f << grover.to_png } | |||
|
|
|||
| You can also pass launch flags like this: `ws://localhost:3000/?--disable-speech-api` | |||
|
|
|||
| If you are only using remote chromium, you better use `puppeteer-core` instead of `puppeteer` to avoid downloading chrome. | |||
There was a problem hiding this comment.
Suggested change
| If you are only using remote chromium, you better use `puppeteer-core` instead of `puppeteer` to avoid downloading chrome. | |
| If you are only using remote chromium, you can install the `puppeteer-core` node package instead of `puppeteer` to avoid downloading chrome. |
| var puppeteer = require(require.resolve('puppeteer-core', { paths: Module._nodeModulePaths(process.cwd()) })); | ||
| } catch (coreError) { | ||
| // raise the original puppeteer load issue so we don't send people don't the wrong rabbit hole by default. | ||
| throw puppeteerError; |
lib/grover/js/processor.cjs
Outdated
| @@ -296,4 +308,4 @@ require('readline').createInterface({ | |||
| } catch(error) { | |||
| _handleError(error); | |||
| } | |||
| }); | |||
| }); | |||
spec/grover/processor_spec.rb
Outdated
| @@ -95,6 +101,23 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'when puppeteer-core package only is installed', :remote_browser do | |||
There was a problem hiding this comment.
Suggested change
| context 'when puppeteer-core package only is installed', :remote_browser do | |
| context 'when only the puppeteer-core package is installed', :remote_browser do |
spec/grover/processor_spec.rb
Outdated
| @@ -1067,4 +1090,4 @@ def mean_colour_statistics(image) | |||
| end | |||
| end | |||
| end | |||
| end | |||
| end | |||
spec/grover/processor_spec.rb
Outdated
Comment on lines
114
to
118
| let(:url_or_html) { '<html><body style="background-color: blue"></body></html>' } | ||
|
|
||
| it 'does not raise' do | ||
| expect { convert }.to_not raise_error | ||
| end |
There was a problem hiding this comment.
Specs look good, but I think we could do better with one that also checks that the result actually was a PDF with the expected content. Something like:
Suggested change
| let(:url_or_html) { '<html><body style="background-color: blue"></body></html>' } | |
| it 'does not raise' do | |
| expect { convert }.to_not raise_error | |
| end | |
| let(:url_or_html) { '<html><body style="background-color: blue">puppeteer-core works!</body></html>' } | |
| it { expect { convert }.not_to raise_error } | |
| it { expect(pdf_text_content).to eq 'puppeteer-core works!' } |
spec/grover/processor_spec.rb
Outdated
Comment on lines
105
to
110
| before do | ||
| FileUtils.move 'node_modules/puppeteer', 'node_modules/puppeteer_temp' | ||
| end | ||
| after do | ||
| FileUtils.move 'node_modules/puppeteer_temp', 'node_modules/puppeteer' | ||
| end |
There was a problem hiding this comment.
Rubocop is either going to want a newline between these, or use the inline block form:
Suggested change
| before do | |
| FileUtils.move 'node_modules/puppeteer', 'node_modules/puppeteer_temp' | |
| end | |
| after do | |
| FileUtils.move 'node_modules/puppeteer_temp', 'node_modules/puppeteer' | |
| end | |
| before { FileUtils.move 'node_modules/puppeteer', 'node_modules/puppeteer_temp' } | |
| after { FileUtils.move 'node_modules/puppeteer_temp', 'node_modules/puppeteer' } |
|
Released in v1.1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using remote chromium
browserless/chrome,puppeteer-coreis more lightweight and avoid download chrome.